Review main Merged

58411[TASK] Add informational upgrade wizard for argon2i

Christian Kuhn CR +2 V +2 Hard +220 −35 updated 09/29/18, 11:28

Commit message

This adds a dummy wizard to remind admins during upgrade
to check the live system for argon2i support if the local
instance uses it, or to select a different hash algorithm.
Having this wizard gives this information to admins early
in the upgrade phase, so they have time to check the live
system or to select a different mechanism before too many
passwords have been upgraded.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2026

Show 1 earlier messages
  1. Christian Kuhn uploaded patch set 1 09/27/18, 13:39

  1. Mathias Brodala commented on patch set 2 09/27/18, 13:41

    Published edit on patch set 1.
  2. Mathias Brodala commented on patch set 2 09/27/18, 13:45

    Argon2iPasswordHashes.php:26

    We should also implement ChattyInterface and have some output in executeUpdate(), otherwise you won't notice if you run "typo3cms upgrade:all" locally.
  3. TYPO3com voted on patch set 1 V -1 09/27/18, 13:50 Completed build in 10m 58s on Thu, 27 Sep, 03:50 PM Test Summary: 1 of 36419 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28724

  4. TYPO3com voted on patch set 2 V +1 09/27/18, 13:53 Completed build in 10m 52s on Thu, 27 Sep, 03:53 PM Test Summary: 36070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28725

  5. Josef Glatz commented on patch set 2 09/27/18, 15:03

    Argon2iPasswordHashes.php:52

    We should add some hints on how this could be evaluated.
  6. Susi Moog commented on patch set 2 09/27/18, 19:47

    Argon2iPasswordHashes.php:26 Reply

    or make it confirmable then the user has to at least acknowledge.
  7. Susi Moog commented on patch set 2 CR -1 09/27/18, 21:06

    on it.
  8. Susi Moog uploaded patch set 3 09/27/18, 21:10

  9. Susi Moog commented on patch set 3 09/27/18, 21:11

    Made the upgrade wizard "forced confirmable". Users have to acknowledge the message now.
  10. Susi Moog commented on patch set 4 09/27/18, 21:19

    Published edit on patch set 3.
  11. TYPO3com voted on patch set 3 V +1 09/27/18, 21:26 Completed build in 12m 50s on Thu, 27 Sep, 11:26 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28763

  12. Frank Nägler voted on patch set 4 V +1 CR +1 09/27/18, 21:30

  13. TYPO3com voted on patch set 4 V +1 09/27/18, 21:34 Completed build in 12m 58s on Thu, 27 Sep, 11:34 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28765

  14. Mathias Brodala commented on patch set 4 09/28/18, 09:32

    Still need to check if the TYPO3 Console already supports this.

    UpgradeWizardRunCommand.php:233

    It would be easier to read/understand if this was $confirmation->isRequired() and that logic was moved to Confirmation instead.

    Confirmation.php:68

    How about "getConfirmResponse()"?

    Confirmation.php:76

    How about "getDeclineResponse()"?
  15. Susi Moog commented on patch set 4 CR -1 09/28/18, 09:48

    good points, will fix
  16. Frank Nägler uploaded patch set 5 09/28/18, 13:03

  17. Frank Nägler voted on patch set 5 V +1 CR +1 09/28/18, 13:17

  18. TYPO3com voted on patch set 5 V +1 09/28/18, 13:19 Completed build in 13m 34s on Fri, 28 Sep, 03:19 PM Test Summary: 36118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28810

  19. Susi Moog commented on patch set 5 CR -1 09/28/18, 13:57

    UpgradeWizardsService.php:314

    this needs to be is required
  20. Frank Nägler uploaded patch set 6 09/28/18, 15:00

  21. Frank Nägler commented on patch set 6 V +1 CR -1 09/28/18, 15:01

    I am fine, but Susi should have final look
  22. TYPO3com voted on patch set 6 V +1 09/28/18, 15:10 Completed build in 09m 32s on Fri, 28 Sep, 05:10 PM Test Summary: 36118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28815

  23. Susi Moog voted on patch set 6 V +1 CR +1 09/29/18, 11:28

  24. Frank Nägler voted on patch set 6 V +2 CR +2 09/29/18, 11:28

  25. Frank Nägler merged patch set 7 09/29/18, 11:28