Review main Merged

58412[BUGFIX] Correctly resolve parameter for USER display condition

Nicole Hummel CR +2 V +2 Normal +90 −35 updated 10/28/18, 14:35

Commit message

According to the documentation there is no limit of the used
additional parameters. However during parameter processing, there
is a limit of 4 parameters applied. This limit needs to be unset
when dealing with a USER display condition.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Nicole Hummel uploaded patch set 1 09/27/18, 13:56

  2. TYPO3com voted on patch set 1 V -1 09/27/18, 14:06 Completed build in 09m 53s on Thu, 27 Sep, 04:06 PM Test Summary: 3 of 36421 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28727

  3. Nicole Hummel uploaded patch set 2 09/27/18, 14:26

  4. TYPO3com voted on patch set 2 V -1 09/27/18, 14:38 Completed build in 12m 18s on Thu, 27 Sep, 04:38 PM Test Summary: 3 of 36421 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28729

  5. Nicole Hummel uploaded patch set 3 09/28/18, 10:16

  6. TYPO3com voted on patch set 3 V +1 09/28/18, 10:27 Completed build in 11m 19s on Fri, 28 Sep, 12:27 PM Test Summary: 36100 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28788

  7. Daniel Goerz commented on patch set 3 10/28/18, 13:10

    Just by reading I am confused. The issues talks about a limit of two params. The unittest of the patch tests for three and the commit message states a limit of four. This needs to say "2", right?
  8. Nicole Hummel commented on patch set 3 10/28/18, 13:26

    Hope my comment helps to understand the situation a bit better.

    EvaluateDisplayConditions.php:261

    Here the condition is split into 4 different parts. The first part is always 'USER', the second part contains the class and method names. The other two parts can be any given parameter. The forth parameter might contain a colon as user functions might need more parameters to be able to validate the condition. The example in the documentation for the user function contains three additional parameters after the user function declaration which gets parsed as "some" and "more:info"
  9. Daniel Goerz commented on patch set 3 10/28/18, 13:32

    EvaluateDisplayConditions.php:261 Reply

    Ah, thanks for pointing me to this line. Now I understand the commit message :)
  10. Daniel Goerz voted on patch set 3 V +1 CR +1 10/28/18, 14:10

  11. Benni Mack commented on patch set 3 V +2 CR +2 10/28/18, 14:34

    thanks to both of you!
  12. Benni Mack merged patch set 4 10/28/18, 14:35