Review main Merged

58414[TASK] Deprecate internal_type=file and file_reference

Benni Mack CR +2 V +2 Normal +224 −1 updated 09/27/18, 18:41

Commit message

TCA "type=group" with "internal_type=file" and "internal_type=file_reference"
are the last parts of content related file handling that circumvent FAL.

All usages in the core have been changed since TYPO3 v6 until TYPO3 v9.

To prepare and unlock further file system related works in v10, it is
important we finally get rid of these parts that low level handles
uploads/ and other legacy functionality.

The patch finds any usages via TcaMigration, notes them as
deprecated and adds a series of hints to core places that can be
removed in v10. Note there is probably some hidden handling
left in the core, this is partially hard to find. We may stumble
upon more details in v10, but will have the freedom to remove
them then.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 57

  1. Benni Mack uploaded patch set 1 09/27/18, 16:57

  2. Christian Kuhn updated the commit message in patch set 2 09/27/18, 17:05

  3. TYPO3com voted on patch set 1 V +1 09/27/18, 17:07 Completed build in 09m 53s on Thu, 27 Sep, 07:07 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28735

  4. TYPO3com voted on patch set 2 V +1 09/27/18, 17:16 Completed build in 11m 11s on Thu, 27 Sep, 07:16 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28736

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 09/27/18, 17:19

  6. Wouter Wolters voted on patch set 2 V +2 CR +2 09/27/18, 18:41

  7. Wouter Wolters merged patch set 3 09/27/18, 18:41