Review main Merged

58415[BUGFIX] Resolve relative file path during copy correctly

Oliver Hader CR +2 V +2 Easy +2 −2 updated 09/27/18, 19:19

Commit message

In composer mode several directories are arranged outside the
public root-path. When trying to copy to those folders, the
public root-path is prefixed due an invalid check which is
too strict. The expectation is to use public root-path
(PATH_site) when resolving relative paths here.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Oliver Hader uploaded patch set 1 09/27/18, 18:15

  2. Frank Nägler voted on patch set 1 CR +1 09/27/18, 18:19

  3. TYPO3com voted on patch set 1 V +1 09/27/18, 18:25 Completed build in 10m 13s on Thu, 27 Sep, 08:25 PM Test Summary: 36070 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28741

  4. Wouter Wolters voted on patch set 1 CR +1 09/27/18, 18:42

  5. Susi Moog voted on patch set 1 V +1 CR +1 09/27/18, 19:17

  6. Frank Nägler voted on patch set 1 V +2 CR +2 09/27/18, 19:19

  7. Frank Nägler merged patch set 2 09/27/18, 19:19