Review main Merged

58419[TASK] Prepare Site handling for extended page routing

Benni Mack CR +2 V +2 Normal +48 −9 updated 09/27/18, 20:33

Commit message

An additional trait for site languages and some minor simplifications
when fetching the PageRouter from a Site.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Benni Mack uploaded patch set 1 09/27/18, 20:05

  2. Benni Mack commented on patch set 2 09/27/18, 20:08

    Published edit on patch set 1.
  3. Benni Mack rebased onto patch set 3 09/27/18, 20:14

  4. TYPO3com voted on patch set 1 V +1 09/27/18, 20:18 Completed build in 13m 13s on Thu, 27 Sep, 10:18 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28749

  5. TYPO3com voted on patch set 2 V +1 09/27/18, 20:22 Completed build in 12m 28s on Thu, 27 Sep, 10:22 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28750

  6. TYPO3com voted on patch set 3 V +1 09/27/18, 20:26 Completed build in 11m 30s on Thu, 27 Sep, 10:26 PM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28751

  7. Susi Moog voted on patch set 3 V +1 CR +1 09/27/18, 20:29

  8. Frank Nägler voted on patch set 3 V +2 CR +2 09/27/18, 20:32

  9. Benni Mack merged patch set 4 09/27/18, 20:33