Review main Merged

58420[TASK] Deprecate TSFE->makeCacheHash()

Benni Mack CR +2 V +2 Normal +185 −27 updated 09/28/18, 09:10

Commit message

The functionality is moved into a new PSR-15 middleware
to base the logic on the request object directly, and
to make the validation more flexible when validating
page parameters for site-based routing.

The previous deprecation to add the request object
to the method has been reverted.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Jan Helke +1
    • Oliver Hader +1
  • Verified V +2
    • Frank Nägler +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1116

  1. Benni Mack uploaded patch set 1 09/27/18, 22:46

  2. TYPO3com voted on patch set 1 V -1 09/27/18, 22:56 Completed build in 09m 55s on Fri, 28 Sep, 12:56 AM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28770

  3. Benni Mack uploaded patch set 2 09/27/18, 22:59

  4. TYPO3com voted on patch set 2 V +1 09/27/18, 23:09 Completed build in 10m 12s on Fri, 28 Sep, 01:09 AM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28771

  5. Oliver Hader uploaded patch set 3 09/28/18, 06:47

  6. Oliver Hader voted on patch set 3 CR +1 09/28/18, 06:55

  7. TYPO3com voted on patch set 3 V +1 09/28/18, 06:59 Completed build in 11m 14s on Fri, 28 Sep, 08:59 AM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28775

  8. Frank Nägler uploaded patch set 4 09/28/18, 08:30

  9. Frank Nägler voted on patch set 4 CR +1 09/28/18, 08:35

  10. TYPO3com voted on patch set 4 V -1 09/28/18, 08:39 Completed build in 08m 29s on Fri, 28 Sep, 10:39 AM Test Summary: 8 of 36445 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28785

  11. Frank Nägler voted on patch set 4 V +1 09/28/18, 08:44

  12. Jan Helke voted on patch set 4 V +1 CR +1 09/28/18, 08:45

  13. TYPO3com voted on patch set 4 V +1 09/28/18, 08:49 Completed build in 27m 10s on Fri, 28 Sep, 10:49 AM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28785

  14. Oliver Hader voted on patch set 4 CR +1 09/28/18, 09:07

  15. Frank Nägler voted on patch set 4 V +2 CR +2 09/28/18, 09:10

  16. Frank Nägler merged patch set 5 09/28/18, 09:10