58420[TASK] Deprecate TSFE->makeCacheHash()
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Jan Helke +1
- Oliver Hader +1
-
Verified V +2
- Frank Nägler +2
- Jan Helke +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/9.4/Deprecation-86046-AdditionalArgumentsInSeveralTypoScriptFrontendControllerMethods.rst+0 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-86411-TSFE-makeCacheHash.rstnew+35 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+7 −13
- typo3/sysext/frontend/Classes/Middleware/PageParameterValidator.phpnew+124 −0
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php+0 −3
- typo3/sysext/frontend/Classes/Page/CacheHashCalculator.php+1 −1
- typo3/sysext/frontend/Configuration/RequestMiddlewares.php+10 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php+0 −7
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+7 −0
Review log 1116
-
Benni Mack uploaded patch set 1 09/27/18, 22:46
-
TYPO3com voted on patch set 1 V -1 09/27/18, 22:56 Completed build in 09m 55s on Fri, 28 Sep, 12:56 AM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28770
-
Benni Mack uploaded patch set 2 09/27/18, 22:59
-
TYPO3com voted on patch set 2 V +1 09/27/18, 23:09 Completed build in 10m 12s on Fri, 28 Sep, 01:09 AM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28771
-
Oliver Hader uploaded patch set 3 09/28/18, 06:47
-
Oliver Hader voted on patch set 3 CR +1 09/28/18, 06:55
-
TYPO3com voted on patch set 3 V +1 09/28/18, 06:59 Completed build in 11m 14s on Fri, 28 Sep, 08:59 AM Test Summary: 36076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28775
-
Frank Nägler uploaded patch set 4 09/28/18, 08:30
-
Frank Nägler voted on patch set 4 CR +1 09/28/18, 08:35
-
TYPO3com voted on patch set 4 V -1 09/28/18, 08:39 Completed build in 08m 29s on Fri, 28 Sep, 10:39 AM Test Summary: 8 of 36445 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28785
-
Frank Nägler voted on patch set 4 V +1 09/28/18, 08:44
-
Jan Helke voted on patch set 4 V +1 CR +1 09/28/18, 08:45
-
TYPO3com voted on patch set 4 V +1 09/28/18, 08:49 Completed build in 27m 10s on Fri, 28 Sep, 10:49 AM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28785
-
Oliver Hader voted on patch set 4 CR +1 09/28/18, 09:07
-
Frank Nägler voted on patch set 4 V +2 CR +2 09/28/18, 09:10
-
Frank Nägler merged patch set 5 09/28/18, 09:10