Review TYPO3_8-7 Merged

58422[BUGFIX] Correct inline foreign_unique with target type="group" handling

Cyril Janody CR +2 V +2 Easy +17 −7 updated 10/11/18, 18:39

Commit message

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Review

  • Code review CR +2
    • Anja Leichsenring +2
  • Verified V +2
    • Anja Leichsenring +2

Issues 2

Files 2

Review log 810

  1. Cyril Janody uploaded patch set 1 09/27/18, 23:53

  2. TYPO3com voted on patch set 1 V +1 09/27/18, 23:59 Completed build in 05m 50s on Fri, 28 Sep, 01:59 AM Test Summary: 59486 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2988

  3. Josef Glatz commented on patch set 1 CR -1 09/28/18, 04:39

    Thanks for your patch! It's enough to push only a patch for the master as it seems like the patch can be easily cherrypicked by a core team member to 8.7 if the patch for the master get's merged. I would suggest to abandon this one and leave the other
  4. Cyril Janody abandoned the change 09/28/18, 12:01

    Hi Josef, Ok, I didn't remember that point. Thank you. Regards
  5. Anja Leichsenring restored the change 10/11/18, 18:30

  6. Anja Leichsenring commented on patch set 1 10/11/18, 18:31

    restored in order to provide the backport after master has been merged.
  7. Anja Leichsenring uploaded patch set 3 10/11/18, 18:31

  8. Anja Leichsenring commented on patch set 3 V +2 CR +2 10/11/18, 18:32

    straight backport
  9. Anja Leichsenring merged patch set 4 10/11/18, 18:32

  10. TYPO3com voted on patch set 3 V +1 10/11/18, 18:39 Completed build in 07m 50s on Thu, 11 Oct, 08:39 PM Test Summary: 59528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3029