58426[BUGFIX] Add missing copy and cut button in file list search result
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Daniel Goerz +1
-
Verified V +2
- Benni Mack +2
- Daniel Goerz +1
- Felix Althaus +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 4252
Show 1927 earlier messages
-
Gianluigi Martino uploaded patch set 1 09/28/18, 06:57
-
TYPO3com voted on patch set 1 V -1 09/28/18, 06:58 Completed build in 15s on Fri, 28 Sep, 08:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28777
-
Stephan Großberndt updated the commit message in patch set 2 09/28/18, 07:04
-
TYPO3com voted on patch set 2 V -1 09/28/18, 07:04 Completed build in 09s on Fri, 28 Sep, 09:04 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28778
-
Tymoteusz Motylewski commented on patch set 2 09/28/18, 10:09
Hi Gianluigi, The tests are red because of some CGL violation. Please fetch the newest patchset, run Build/Scripts/cglFixMyCommit.sh And commit (amend) changes. -
Gianluigi Martino uploaded patch set 3 09/28/18, 10:52
-
TYPO3com voted on patch set 3 V +1 09/28/18, 11:03 Completed build in 11m 22s on Fri, 28 Sep, 01:03 PM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28792
-
Josef Glatz commented on patch set 3 CR -1 09/28/18, 18:50
CopyCutFileViewHelper.php:1<?php declare(strict_types=1); or is there a reason to not use? -
Guido Schmechel commented on patch set 3 09/29/18, 08:42
CopyCutFileViewHelper.php:67Unresolved=== -
Gianluigi Martino uploaded patch set 4 10/01/18, 17:13
-
TYPO3com voted on patch set 4 V +1 10/01/18, 17:30 Completed build in 15m 21s on Mon, 1 Oct, 07:30 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29208
-
Josef Glatz commented on patch set 5 10/01/18, 18:03
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 10/01/18, 18:24 Completed build in 17m 22s on Mon, 1 Oct, 08:24 PM Test Summary: 36928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29217
-
Josef Glatz updated the commit message in patch set 6 10/01/18, 19:03
-
Josef Glatz voted on patch set 6 V +1 CR +1 10/01/18, 19:07
-
Josef Glatz commented on patch set 6 V 0 CR -1 10/01/18, 19:09
What is the reason for the mentioned issue id? Why not #86414? The title of #63916 doesn't have anything todo with the filelist and is only a related issue? -
TYPO3com voted on patch set 6 V +1 10/01/18, 19:12 Completed build in 09m 27s on Mon, 1 Oct, 09:12 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29224
-
Gianluigi Martino uploaded patch set 7 10/02/18, 06:10
-
Gianluigi Martino commented on patch set 7 V +1 CR +1 10/02/18, 06:12
Stephan Grossberndt changed the forge id, but i don't know why. For me this is the right one, so everything should be ok. -
TYPO3com voted on patch set 7 V +1 10/02/18, 06:21 Completed build in 11m 06s on Tue, 2 Oct, 08:21 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29251
-
Josef Glatz voted on patch set 7 CR +1 10/03/18, 03:52
-
Jasmina Ließmann voted on patch set 7 V +1 10/26/18, 08:47
-
Daniel Goerz commented on patch set 7 CR -1 10/26/18, 09:39
On it -
Daniel Goerz uploaded patch set 8 10/26/18, 10:14
-
TYPO3com voted on patch set 8 V +1 10/26/18, 10:28 Completed build in 13m 24s on Fri, 26 Oct, 12:28 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29586
-
Gianluigi Martino voted on patch set 8 V +1 CR +1 10/26/18, 10:33
-
Jasmina Ließmann voted on patch set 8 V +1 10/26/18, 10:40
-
Joerg Kummer voted on patch set 8 V +1 10/26/18, 14:10
-
Daniel Goerz voted on patch set 8 V +1 CR +1 10/28/18, 12:45
-
Felix Althaus updated the commit message in patch set 9 10/28/18, 12:48
-
Benni Mack updated the commit message in patch set 10 10/28/18, 12:55
-
Daniel Goerz voted on patch set 10 V +1 CR +1 10/28/18, 12:56
-
Felix Althaus commented on patch set 9 V -1 10/28/18, 12:57
Document header template misses the buttons and maybe therefor the Javascript. Files are not transferred to the clipboard. -
Felix Althaus commented on patch set 10 V -1 10/28/18, 13:00
see above my comment to patch set 9 -
Benni Mack commented on patch set 10 10/28/18, 13:13
is this one related? https://review.typo3.org/#/c/58060/ -
Felix Althaus commented on patch set 10 10/28/18, 13:16
See screenshot in the linked issue. -
Daniel Goerz commented on patch set 10 10/28/18, 13:17
> is this one related? https://review.typo3.org/#/c/58060/ I looked at that one, too. It is the same topic but a different issue (not even sure if its valid). -
Gianluigi Martino commented on patch set 10 10/28/18, 13:17
@Benni No, it is not related.. -
TYPO3com voted on patch set 9 V +1 10/28/18, 13:21 Completed build in 31m 52s on Sun, 28 Oct, 02:21 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29756
-
Gianluigi Martino commented on patch set 10 10/28/18, 13:29
@Felix, this path only adds the copy and cut buttons and this seems to work. it would be nice to see others patches for the things you write in the forge ticket, but it has nothing to do with that what this patch does.. -
Anja Leichsenring commented on patch set 10 10/28/18, 13:31
> Patch Set 10: > > @Felix, this path only adds the copy and cut buttons and this seems to work. it would be nice to see others patches for the things you write in the forge ticket, but it has nothing to do with that what this patch does.. so you say the buttons are there, and this is the extend of the patch? I can not do anything with the presumably cut/copied file, but this would be another patch? This feels strange to me, sorry. -
TYPO3com voted on patch set 10 V +1 10/28/18, 13:35 Completed build in 26m 41s on Sun, 28 Oct, 02:35 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29759
-
Daniel Goerz commented on patch set 10 10/28/18, 13:36
> > Patch Set 10: > > > > @Felix, this path only adds the copy and cut buttons and this > seems to work. it would be nice to see others patches for the > things you write in the forge ticket, but it has nothing to do with > that what this patch does.. > > so you say the buttons are there, and this is the extend of the > patch? I can not do anything with the presumably cut/copied file, > but this would be another patch? > This feels strange to me, sorry. Anja, did you test the patch? Of course you can paste the file that was cut/copied. I am currently trying to figure out with Felix what the issues are that he encounters but please dont jump to conclusions so quickly. Thanks. -
Gianluigi Martino commented on patch set 10 10/28/18, 13:36
@Anja, no the copy and cut buttons should work. Can somebody confirm that this doesn't works? I see a lot of verfied +1 here and for me it seems to work. but this patch have nothing to do with the other three things that Alex write in the forge ticket, this is what i mean.. -
Anja Leichsenring commented on patch set 10 10/28/18, 13:37
> Patch Set 10: > > > > Patch Set 10: > > > > > > @Felix, this path only adds the copy and cut buttons and this > > seems to work. it would be nice to see others patches for the > > things you write in the forge ticket, but it has nothing to do with > > that what this patch does.. > > > > so you say the buttons are there, and this is the extend of the > > patch? I can not do anything with the presumably cut/copied file, > > but this would be another patch? > > This feels strange to me, sorry. > > Anja, did you test the patch? Of course you can paste the file that was cut/copied. I am currently trying to figure out with Felix what the issues are that he encounters but please dont jump to conclusions so quickly. Thanks. I tested, an I sit next to Felix. No entry to put the copied/pasted file somewhere, when taken from search result. That is exactly my issue. -
Felix Althaus commented on patch set 10 10/28/18, 13:55
We narrowed the prob down a bit: seems to be a chromium on linux issue -
Anja Leichsenring commented on patch set 10 10/28/18, 13:56
> Patch Set 10: > > We narrowed the prob down a bit: > seems to be a chromium on linux issue jupp, confirmed. Chromium fails (no reload after button click), works in FF and Chrome. Very strange. -
Felix Althaus commented on patch set 10 10/28/18, 13:56
Version 70.0.3538.77 (Offizieller Build) snap (64-Bit) if that matters -
Felix Althaus commented on patch set 10 V 0 10/28/18, 14:00
Sorry folks. Was just aggressive browser caching. Should have checked earlier. -
Felix Althaus voted on patch set 10 V +1 10/28/18, 14:04
-
Benni Mack voted on patch set 10 V +2 CR +2 10/28/18, 16:15
-
Benni Mack merged patch set 11 10/28/18, 16:15