Review main Merged

58430[BUGFIX] Change visibility of two properties to public

Christian Kuhn CR +2 V +2 Easy +4 −6 updated 09/28/18, 12:44

Commit message

Properties $MOD_SETTINGS and $modTSconfig of RecordListController
are still used by DatabaseRecordList through $GLOBALS['SOBE'].
These two have to stay public for the time being to not trigger
a bunch of deprecation log entries on each call of the list module.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mathias Brodala +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 09/28/18, 11:12

  2. TYPO3com voted on patch set 1 V +1 09/28/18, 11:23 Completed build in 11m 07s on Fri, 28 Sep, 01:23 PM Test Summary: 36097 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28795

  3. Mathias Brodala commented on patch set 1 V +1 CR +1 09/28/18, 12:01

    We really need to kill SOBE. :-/
  4. Christian Kuhn commented on patch set 1 09/28/18, 12:27

    yeah. i think sobe can fall in v10. this has been isolated much better in v9 and we dropped lots of assignments already.
  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/28/18, 12:44

  6. Anja Leichsenring merged patch set 2 09/28/18, 12:44