Review main Merged

58438[BUGFIX] Transform language parameter when previewing translated pages

Oliver Hader CR +2 V +2 Easy +7 −1 updated 09/28/18, 19:27

Commit message

When previewing translated pages in the backend, URLs contain `&L=x` at
the end. This is due to a missing transformation into the `_language`
parameter as well a missing SiteLanguage resolving.

Review

  • Code review CR +2
    • Benni Mack +2
    • Josef Glatz +1
    • Richard Haeser +1
  • Verified V +2
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 810

  1. Oliver Hader uploaded patch set 1 09/28/18, 16:38

  2. TYPO3com voted on patch set 1 V +1 09/28/18, 16:51 Completed build in 12m 17s on Fri, 28 Sep, 06:51 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28819

  3. Richard Haeser voted on patch set 1 V +1 CR +1 09/28/18, 18:18

  4. Josef Glatz updated the commit message in patch set 2 09/28/18, 18:52

  5. Richard Haeser voted on patch set 2 V +1 CR +1 09/28/18, 18:53

  6. Josef Glatz commented on patch set 2 09/28/18, 18:55

    I'm not sure, but I would rather suggest: URLs include the parameter `&L=x` when previewing translated pages in the backend.
  7. TYPO3com voted on patch set 2 V +1 09/28/18, 19:05 Completed build in 11m 45s on Fri, 28 Sep, 09:05 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28831

  8. Josef Glatz voted on patch set 2 CR +1 09/28/18, 19:06

  9. Benni Mack voted on patch set 2 V +2 CR +2 09/28/18, 19:27

  10. Benni Mack merged patch set 3 09/28/18, 19:27