Review main Abandoned

58440[WIP][FEATURE] Hand PSR-7 request into cObjects and Extbase Plugins

Benni Mack CR 0 V 0 Hard +281 −94 updated 09/29/18, 22:37

Commit message

The following methods in TSFE now need a PSR-7 request object
->TSFE->cObj()
->ContentObjectRenderer->__contruct()

Now all cObjects and all content object userFunc functionalities
receive the current Request object if they ever going to implement
->setRequest().

And finally we have a new "FrontendPluginRequestHandler" in extbase
which allows to build the query based off the handed PSR-7 Request
object instead of global GET / POST parameters.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 47

  1. Benni Mack uploaded patch set 1 09/28/18, 18:27

  2. TYPO3com voted on patch set 1 V -1 09/28/18, 18:36 Completed build in 08m 33s on Fri, 28 Sep, 08:36 PM Test Summary: 2988 of 36469 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28826

  3. Benni Mack uploaded patch set 2 09/29/18, 15:19

  4. TYPO3com voted on patch set 2 V -1 09/29/18, 15:19 Completed build in 05s on Sat, 29 Sep, 05:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28906

  5. Benni Mack uploaded patch set 3 09/29/18, 15:21

  6. TYPO3com voted on patch set 3 V -1 09/29/18, 15:32 Completed build in 11m 33s on Sat, 29 Sep, 05:32 PM Test Summary: 2980 of 36551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28907

  7. Benni Mack abandoned the change 09/29/18, 22:37

    not gonna work in the near future