58441[TASK] Improve styling of infobox in ImageManipulationElement
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Josef Glatz +1
- Andreas Kienast +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Josef Glatz +1
- Andreas Kienast +1
Issues 1
Files 1
Review log 1926
Show 1 earlier messages
-
Georg Ringer uploaded patch set 1 09/28/18, 19:36
-
Andreas Kienast commented on patch set 1 CR -1 09/28/18, 19:43
-
TYPO3com voted on patch set 1 V +1 09/28/18, 19:47 Completed build in 10m 52s on Fri, 28 Sep, 09:47 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28834
-
Georg Ringer uploaded patch set 2 09/28/18, 19:52
-
Josef Glatz voted on patch set 2 V +1 CR +1 09/28/18, 19:54
-
Josef Glatz commented on patch set 2 09/28/18, 19:58
You can test it by uploading a svg without any dimensions (no viewbox, no sizes, no styles..) -
TYPO3com voted on patch set 2 V +1 09/28/18, 20:01 Completed build in 08m 23s on Fri, 28 Sep, 10:01 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28837
-
Andreas Kienast commented on patch set 2 CR -1 09/28/18, 20:10
ImageManipulationElement.html:65UnresolvedWhy did you remove the h4 now? Only the given class name war wrong... -
Josef Glatz commented on patch set 2 09/28/18, 20:12
Both OK for me. It looks a bit more modern with a h4 -
Josef Glatz voted on patch set 2 V 0 CR 0 09/28/18, 20:12
-
Andreas Kienast uploaded patch set 3 09/28/18, 20:12
-
Georg Ringer voted on patch set 3 V +1 CR +1 09/28/18, 20:13
-
Josef Glatz updated the commit message in patch set 4 09/28/18, 20:13
-
Josef Glatz updated the commit message in patch set 5 09/28/18, 20:14
-
Josef Glatz updated the commit message in patch set 6 09/28/18, 20:15
-
Andreas Kienast voted on patch set 6 V +1 CR +1 09/28/18, 20:15
-
Josef Glatz updated the commit message in patch set 7 09/28/18, 20:15
-
Andreas Kienast voted on patch set 7 V +1 CR +1 09/28/18, 20:16
-
Josef Glatz voted on patch set 7 V +1 CR +1 09/28/18, 20:17
-
TYPO3com voted on patch set 3 V +1 09/28/18, 20:21 Completed build in 08m 59s on Fri, 28 Sep, 10:21 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28839
-
Tymoteusz Motylewski voted on patch set 7 V +2 CR +2 09/28/18, 20:21
-
Tymoteusz Motylewski merged patch set 8 09/28/18, 20:21
-
TYPO3com voted on patch set 4 V +1 09/28/18, 20:25 Completed build in 11m 50s on Fri, 28 Sep, 10:25 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28840
-
TYPO3com voted on patch set 5 V +1 09/28/18, 20:30 Completed build in 12m 14s on Fri, 28 Sep, 10:30 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28841
-
TYPO3com voted on patch set 6 V +1 09/28/18, 20:33 Completed build in 15m 33s on Fri, 28 Sep, 10:33 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28842
-
TYPO3com voted on patch set 7 V +1 09/28/18, 20:39 Completed build in 20m 57s on Fri, 28 Sep, 10:39 PM Test Summary: 36121 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28843
ImageManipulationElement.html:66Unresolved