Review main Merged

58451[TASK] Create .htaccess or web.config file upon installation

Christian Kuhn CR +2 V +2 Easy +21 −2 updated 09/29/18, 14:27

Commit message

With the new routing, TYPO3 relies on a default redirect to index.php
for FE requests. The patch checks during installation if apache or IIS
are used and creates the default .htaccess / web.config files.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Frank Nägler +1
  • Verified V +2
    • Anja Leichsenring +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Christian Kuhn uploaded patch set 1 09/29/18, 10:32

  2. TYPO3com voted on patch set 1 V -1 09/29/18, 10:43 Completed build in 11m 39s on Sat, 29 Sep, 12:43 PM Test Summary: 3 of 36470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28877

  3. Christian Kuhn uploaded patch set 2 09/29/18, 11:09

  4. TYPO3com voted on patch set 2 V +1 09/29/18, 11:21 Completed build in 11m 09s on Sat, 29 Sep, 01:21 PM Test Summary: 36122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28884

  5. Frank Nägler voted on patch set 2 CR +1 09/29/18, 11:46

  6. Frank Nägler commented on patch set 2 V +1 09/29/18, 11:52

    verified for apache, no ISS available in my case.
  7. Christian Kuhn commented on patch set 2 09/29/18, 13:02

    should do, frank. i took the "if's" from benjis boostrap_package and hack both varians locally to verify the files are created.
  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/29/18, 13:03

  9. Anja Leichsenring merged patch set 3 09/29/18, 13:03

  10. Benni Mack commented on patch set 3 09/29/18, 14:27

    Post -1. INSTALL.md and DefaultConfigurationDescription was not modified to explain moving of this file into a different location.