58456[TASK] Mark several methods within TemplateService as internal
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php1+26 −9
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-86439-MarkSeveralMethodsWithinTemplateServiceAsInternal.rst3new+41 −0
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+0 −17
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+42 −0
Review log 1623
-
Benni Mack uploaded patch set 1 09/29/18, 14:06
-
TYPO3com voted on patch set 1 V -1 09/29/18, 14:16 Completed build in 09m 30s on Sat, 29 Sep, 04:16 PM Test Summary: 3 of 36470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28897
-
Benni Mack uploaded patch set 2 09/29/18, 16:40
-
TYPO3com voted on patch set 2 V -1 09/29/18, 16:50 Completed build in 08m 59s on Sat, 29 Sep, 06:50 PM Test Summary: 3 of 36551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28913
-
Benni Mack uploaded patch set 3 09/29/18, 17:35
-
TYPO3com voted on patch set 3 V +1 09/29/18, 17:50 Completed build in 12m 30s on Sat, 29 Sep, 07:50 PM Test Summary: 36188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28924
-
Benni Mack commented on patch set 3 CR -2 09/29/18, 17:56
RST file missing -
Georg Ringer uploaded patch set 4 09/29/18, 18:03
-
Georg Ringer uploaded patch set 5 09/29/18, 18:13
-
TYPO3com voted on patch set 4 V +1 09/29/18, 18:19 Completed build in 13m 09s on Sat, 29 Sep, 08:19 PM Test Summary: 36188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28930
-
TYPO3com voted on patch set 5 V +1 09/29/18, 18:23 Completed build in 10m 30s on Sat, 29 Sep, 08:23 PM Test Summary: 36188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28931
-
Benni Mack voted on patch set 5 CR 0 09/29/18, 18:34
-
Benni Mack commented on patch set 5 09/29/18, 18:34
we also need ExtensionScanner files -
Benni Mack uploaded patch set 6 09/29/18, 19:15
-
Georg Ringer voted on patch set 6 V +1 CR +1 09/29/18, 19:26
-
Andreas Kienast commented on patch set 6 CR -1 09/29/18, 19:26
on itTemplateService.php:1098UnresolvedCan be dropped, IMODeprecation-86439-MarkSeveralMethodsWithinTemplateServiceAsInternal.rst:28UnresolvedThis sentences doesn't make much sense, the methods themselves are not deprecated, but only the calls in "public" scope.Deprecation-86439-MarkSeveralMethodsWithinTemplateServiceAsInternal.rst:34Unresolvedextensions -
Andreas Kienast uploaded patch set 7 09/29/18, 19:30
-
Andreas Kienast voted on patch set 7 V +1 CR +1 09/29/18, 19:30
-
TYPO3com voted on patch set 6 V +1 09/29/18, 19:44 Completed build in 28m 32s on Sat, 29 Sep, 09:44 PM Test Summary: 36188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28948
-
TYPO3com voted on patch set 7 V +1 09/29/18, 19:56 Completed build in 19m 05s on Sat, 29 Sep, 09:56 PM Test Summary: 36188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28950
-
Benni Mack voted on patch set 7 V +2 CR +2 09/29/18, 20:02
-
Benni Mack merged patch set 8 09/29/18, 20:02
-
Christian Kuhn commented on patch set 8 09/30/18, 10:43
Deprecation-86439-MarkSeveralMethodsWithinTemplateServiceAsInternal.rst:41NotScanned is wrong here, this is at least PartiallyScanned, maybe even FullyScanned?