Review main Merged

58457[TASK] Mark several parts within RteHtmlParser as internal

Benni Mack CR +2 V +2 Hard +251 −44 updated 09/30/18, 10:46

Commit message

RteHtmlParser has never received a good clean up, that's
because it was there since PHP 4 ages.

In order to rename, reorder code, all internal methods
and properties are now declared as protected.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Frank Nägler +1
  • Verified V +2
    • Oliver Hader +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 912

  1. Benni Mack uploaded patch set 1 09/29/18, 14:23

  2. TYPO3com voted on patch set 1 V -1 09/29/18, 14:31 Completed build in 08m 29s on Sat, 29 Sep, 04:31 PM Test Summary: 372 of 36470 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28899

  3. Benni Mack uploaded patch set 2 09/29/18, 20:31

  4. TYPO3com voted on patch set 2 V +1 09/29/18, 20:41 Completed build in 09m 59s on Sat, 29 Sep, 10:41 PM Test Summary: 36184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28958

  5. Frank Nägler uploaded patch set 3 09/29/18, 20:54

  6. Frank Nägler voted on patch set 3 V +1 CR +1 09/29/18, 20:54

  7. TYPO3com voted on patch set 3 V +1 09/29/18, 21:04 Completed build in 10m 49s on Sat, 29 Sep, 11:04 PM Test Summary: 36184 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28961

  8. Oliver Hader voted on patch set 3 CR +1 09/29/18, 21:08

  9. Oliver Hader voted on patch set 3 V +1 09/29/18, 22:10

  10. Oliver Hader voted on patch set 3 V +2 CR +2 09/29/18, 22:10

  11. Oliver Hader merged patch set 4 09/29/18, 22:10

  12. Christian Kuhn commented on patch set 4 09/30/18, 10:46

    Deprecation-86440-InternalMethodsAndPropertiesWithinRteHtmlParser.rst:65

    tag php-api missing