Review main Merged

58458[TASK] Deprecate various methods inside BE_USER

Benni Mack CR +2 V +2 Normal +100 −25 updated 09/30/18, 12:49

Commit message

The property "checkWorkspaceCurrent_cache" is now protected.

Second method argument of "modAccess()" is deprecated.

"isPSet()" is not in use anymore, and will be removed in TYPO3 v10.0.

Some other methods, which are workspace-related, are marked
as internal in order to properly move them into EXT:workspaces
in the next version.

Review

  • Code review CR +2
    • Susi Moog +2
    • Frank Nägler +1
  • Verified V +2
    • Susi Moog +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 811

  1. Benni Mack uploaded patch set 1 09/29/18, 14:26

  2. TYPO3com voted on patch set 1 V +1 09/29/18, 14:37 Completed build in 11m 04s on Sat, 29 Sep, 04:37 PM Test Summary: 36122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28900

  3. Benni Mack uploaded patch set 2 09/29/18, 15:45

  4. Benni Mack uploaded patch set 3 09/29/18, 15:47

  5. TYPO3com voted on patch set 2 V +1 09/29/18, 15:56 Completed build in 10m 31s on Sat, 29 Sep, 05:56 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28908

  6. TYPO3com voted on patch set 3 V +1 09/29/18, 15:58 Completed build in 10m 39s on Sat, 29 Sep, 05:58 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28909

  7. Frank Nägler voted on patch set 3 V +1 CR +1 09/29/18, 16:56

  8. Susi Moog voted on patch set 3 V +2 CR +2 09/29/18, 17:15

  9. Susi Moog merged patch set 4 09/29/18, 17:15

  10. Stefan Neufeind commented on patch set 4 09/29/18, 21:48

    When using the ExtensionScanner I now get an exception which worked fine one day ago. Could it be that's related to the modAccess-change here? Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1500492001: Required matcher definitions missing: offending key: TYPO3\CMS\Core\Authentication\BackendUserAuthentication->modAccess | InvalidArgumentException thrown in file /var/www/htdocs/public/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/AbstractCoreMatcher.php in line 111. Requested URL: http://192.168.56.10/typo3/install.php?install[controller]=upgrade&install[context]=backend
  11. Stefan Neufeind commented on patch set 4 09/30/18, 12:49

    Works now. Must have been an old class-cache or something on my side. Just upgraded to the latest version, fully flushed again - and now my scanner works.