Review main Merged

58459[TASK] Mark various functionality as internal within TSFE

Benni Mack CR +2 V +2 Normal +39 −31 updated 09/29/18, 15:15

Commit message

Use @internal where access private was marked, also add
some meaning to currently public methods that should only
be used by TYPO3 Core.

Review

  • Code review CR +2
    • Ralf Zimmermann +2
    • Susi Moog +1
  • Verified V +2
    • Ralf Zimmermann +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 09/29/18, 14:39

  2. TYPO3com voted on patch set 1 V +1 09/29/18, 14:50 Completed build in 10m 17s on Sat, 29 Sep, 04:50 PM Test Summary: 36122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28903

  3. Susi Moog voted on patch set 1 V +1 CR +1 09/29/18, 15:07

  4. Ralf Zimmermann voted on patch set 1 V +2 CR +2 09/29/18, 15:14

  5. Ralf Zimmermann merged patch set 2 09/29/18, 15:15