Review main Merged

58460[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox

Nikita Hovratov CR +2 V +2 Easy +10 −1 updated 10/01/18, 21:00

Commit message

* The last item in panel-collapse has now proper padding to its bottom.
* With a different behaviour of firefox a container having overflow-y
  ignores padding-bottom. A workaround is a pseudo-element reserving
  the same space as the padding attribute would have.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Josef Glatz +1
    • Daniel Goerz +1
  • Verified V +2
    • Jigal van Hemert +2
    • Josef Glatz +1
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 910

  1. Nikita Hovratov uploaded patch set 1 09/29/18, 16:07

  2. TYPO3com voted on patch set 1 V +1 09/29/18, 16:16 Completed build in 08m 45s on Sat, 29 Sep, 06:16 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28910

  3. Tymoteusz Motylewski commented on patch set 1 09/29/18, 19:51

    Congratulations on your first contribution!
  4. Nikita Hovratov commented on patch set 1 09/29/18, 20:37

    > Patch Set 1: > > Congratulations on your first contribution! Thank you :)
  5. Jigal van Hemert voted on patch set 1 V +1 CR +1 09/30/18, 09:08

  6. Daniel Goerz voted on patch set 1 V +1 CR +1 09/30/18, 17:05

  7. Josef Glatz voted on patch set 1 V +1 CR +1 09/30/18, 17:21

  8. Jigal van Hemert voted on patch set 1 V +2 CR +2 09/30/18, 18:00

  9. Jigal van Hemert merged patch set 2 09/30/18, 18:00

  10. Andreas Kienast commented on patch set 2 10/01/18, 21:00

    This fix has multiple flaws: - Cropper modals are broken now due to the 100% in ::after - Every .modal-body has that padding now