Review main Merged

58466[TASK] Remove @internal on new UpgradeWizard interfaces

Susi Moog CR +2 V +2 Easy +0 −10 updated 09/29/18, 22:23

Commit message

To allow others to use the new upgrade wizard API the
interfaces are no longer marked as @internal.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2
    • Oliver Hader +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 67

  1. Susi Moog uploaded patch set 1 09/29/18, 17:30

  2. Benni Mack commented on patch set 1 09/29/18, 17:37

    shouldn't we rename the intefaces then to `ChattyUpgradeInterface` like we do in all other places of TYPO3 Core?
  3. TYPO3com voted on patch set 1 V +1 09/29/18, 17:45 Completed build in 14m 41s on Sat, 29 Sep, 07:45 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28922

  4. Susi Moog commented on patch set 1 09/29/18, 19:33

    @Benni: I wouldn't because then we have scope duplication in all the interfaces (Updates/UpgradeWizardPrerequisiteInterface instead of Updates/PrerequisiteInterface) - which is rather bulky.
  5. Benni Mack voted on patch set 1 V +1 CR +1 09/29/18, 22:10

  6. Oliver Hader voted on patch set 1 V +2 CR +2 09/29/18, 22:22

  7. Oliver Hader merged patch set 2 09/29/18, 22:23