58466[TASK] Remove @internal on new UpgradeWizard interfaces
Commit message
Review
-
Code review CR +2
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2
- Oliver Hader +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/install/Classes/Updates/ChattyInterface.php+0 −2
- typo3/sysext/install/Classes/Updates/ConfirmableInterface.php+0 −2
- typo3/sysext/install/Classes/Updates/PrerequisiteInterface.php+0 −2
- typo3/sysext/install/Classes/Updates/RepeatableInterface.php+0 −2
- typo3/sysext/install/Classes/Updates/UpgradeWizardInterface.php+0 −2
Review log 67
-
Susi Moog uploaded patch set 1 09/29/18, 17:30
-
Benni Mack commented on patch set 1 09/29/18, 17:37
shouldn't we rename the intefaces then to `ChattyUpgradeInterface` like we do in all other places of TYPO3 Core? -
TYPO3com voted on patch set 1 V +1 09/29/18, 17:45 Completed build in 14m 41s on Sat, 29 Sep, 07:45 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28922
-
Susi Moog commented on patch set 1 09/29/18, 19:33
@Benni: I wouldn't because then we have scope duplication in all the interfaces (Updates/UpgradeWizardPrerequisiteInterface instead of Updates/PrerequisiteInterface) - which is rather bulky. -
Benni Mack voted on patch set 1 V +1 CR +1 09/29/18, 22:10
-
Oliver Hader voted on patch set 1 V +2 CR +2 09/29/18, 22:22
-
Oliver Hader merged patch set 2 09/29/18, 22:23