58467[TASK] Improve styling of upload form in extension manager
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1114
-
Georg Ringer uploaded patch set 1 09/29/18, 17:51
-
TYPO3com voted on patch set 1 V +1 09/29/18, 18:05 Completed build in 11m 50s on Sat, 29 Sep, 08:05 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28927
-
Nikita Hovratov voted on patch set 1 CR +1 09/30/18, 00:21
-
Josef Glatz commented on patch set 1 CR -1 09/30/18, 05:16
+1 for switching to BS3 - But the horizontal alignment (label vs form element) looks broken now (especially the checkbox form-group) - The form moves much too far in the vertical middle If you open form on "bigger" screen (e.g. width 1920px viewport). In addition to that, I would add the upload button tooltip as Heading for the form to make it more clear. "Upload Extension .t3x/.zip" Furthermore the form-group of the checkbox element could be adopted, that the label is on the next side of the checkbox (like you find in the BS3 horizontal-form example) -
Benni Mack commented on patch set 1 10/26/18, 12:47
ping. anyone actually finishing this one? Would be good to have a clean UI for v9 -
Georg Ringer uploaded patch set 2 10/29/18, 11:05
-
TYPO3com voted on patch set 2 V +1 10/29/18, 11:31 Completed build in 25m 01s on Mon, 29 Oct, 12:31 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29817
-
Benni Mack uploaded patch set 3 10/29/18, 14:11
-
Benni Mack voted on patch set 3 V +1 CR +1 10/29/18, 14:12
-
TYPO3com voted on patch set 3 V +1 10/29/18, 14:21 Completed build in 09m 36s on Mon, 29 Oct, 03:21 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29827
-
Susi Moog voted on patch set 3 V +1 CR +1 10/29/18, 15:06
-
Benni Mack voted on patch set 3 V +2 CR +2 10/29/18, 15:13
-
Benni Mack merged patch set 4 10/29/18, 15:13
-
Andreas Kienast commented on patch set 4 10/29/18, 19:05
Post -1: The backend.css has other changes after compiling the CSS again