Review main Merged

58469[TASK] Use PSR-15 RequestHandler in Install Tool

Benni Mack CR +2 V +2 Easy +31 −6 updated 09/29/18, 18:59

Commit message

Install Tool still uses TYPO3's own RequestHandler interface which
exists since TYPO3 v7, but is superseded with PSR-15's
RequestHandler concept.

Install Tool now uses PSR-15 and the old interface in order
to still use the priority concept.

In a further step, both RequestHandlers should be migrated to
Middleware+RequestHandler concept.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Issues 1

Files 4

Review log 57

  1. Benni Mack uploaded patch set 1 09/29/18, 18:13

  2. TYPO3com voted on patch set 1 V +1 09/29/18, 18:27 Completed build in 12m 37s on Sat, 29 Sep, 08:27 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28932

  3. Susi Moog voted on patch set 1 V +1 CR +1 09/29/18, 18:34

  4. Georg Ringer uploaded patch set 2 09/29/18, 18:48

  5. Georg Ringer commented on patch set 2 V +2 CR +2 09/29/18, 18:48

    as just some wording changed, previous +1 are still valid
  6. Georg Ringer merged patch set 3 09/29/18, 18:48

  7. TYPO3com voted on patch set 2 V +1 09/29/18, 18:59 Completed build in 10m 53s on Sat, 29 Sep, 08:59 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28937