Review main Merged

58471[TASK] Use NormalizedParams with simplified arguments

Benni Mack CR +2 V +2 Hard +116 −215 updated 09/29/18, 20:04

Commit message

Normalized Params only needs serverParams and
$TYPO3_CONF_VARS[SYS] to work with, so the object is modified
in order to simplify further work on the object.

Review

  • Code review CR +2
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 710

  1. Benni Mack uploaded patch set 1 09/29/18, 18:32

  2. TYPO3com voted on patch set 1 V -1 09/29/18, 18:42 Completed build in 10m 07s on Sat, 29 Sep, 08:42 PM Test Summary: 15 of 36551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28935

  3. Benni Mack uploaded patch set 2 09/29/18, 19:21

  4. Andreas Kienast commented on patch set 2 CR -1 09/29/18, 19:39

    on it
  5. Andreas Kienast uploaded patch set 3 09/29/18, 19:41

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 09/29/18, 19:46

  7. TYPO3com voted on patch set 2 V +1 09/29/18, 19:49 Completed build in 12m 22s on Sat, 29 Sep, 09:49 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28949

  8. TYPO3com voted on patch set 3 V +1 09/29/18, 19:58 Completed build in 12m 50s on Sat, 29 Sep, 09:58 PM Test Summary: 36191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28951

  9. Susi Moog voted on patch set 3 V +2 CR +2 09/29/18, 20:04

  10. Susi Moog merged patch set 4 09/29/18, 20:04