58472[BUGFIX] Get only valid template records in backend -> Template -> PID 0
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Joerg Kummer +1
-
Verified V +2
- Markus Klein +2
- Joerg Kummer +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1620
-
Ioulia Kondratovitch uploaded patch set 1 09/29/18, 18:42
-
TYPO3com voted on patch set 1 V +1 09/29/18, 18:53 Completed build in 10m 12s on Sat, 29 Sep, 08:53 PM Test Summary: 59528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3007
-
Josef Glatz updated the commit message in patch set 2 09/30/18, 21:32
-
TYPO3com voted on patch set 2 V +1 09/30/18, 21:53 Completed build in 09m 22s on Sun, 30 Sep, 11:53 PM Test Summary: 59528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3014
-
Josef Glatz commented on patch set 2 CR +1 10/01/18, 04:54
The error is gone. When does such a situation occur? (Because if I delete the page within the TYPO3 backend all is ok and ts_template record get's deleted.) I think deleting without the Use of the DataHandler could have many side effects (one is a "zombie" ts_template which flies around in the database without parent ツ) -
Ioulia Kondratovitch commented on patch set 2 10/01/18, 08:27
Hi Josef! Originally the error occured at specific TYPO3-Website of our customer, after I upgraded it to version 8.7.19. The website has a long pre-history. So, i do not know, who when and why deleted some pages reffered by sys_template entries without using DataHandler. Anyway, we have some zombies there. Of course, we can get rid of zombies directly via DB. But this case needs a fallback (patch) anyway, IMHO. This situation cann occure at some other old TYPO3-projects with long pre-history. -
Josef Glatz voted on patch set 2 V +1 10/01/18, 08:42
-
Andreas Wolf commented on patch set 2 10/01/18, 10:44
Why is this only for 8.7 and not for master? Is the problem fixed there already? -
Andreas Wolf commented on patch set 2 CR -1 10/01/18, 10:52
Generally this is fine, just the cartesian product should be changed to a join.TypoScriptTemplateModuleController.php:237Not sure about the performance impact of this compared to a JOIN. Nevertheless, to convey the intent, this should be a JOIN (see https://www.quora.com/Are-joins-faster-than-Cartesian-products-in-RDBMS-like-SQL-server-or-MySQL) -
Josef Glatz commented on patch set 2 10/01/18, 11:08
> Why is this only for 8.7 and not for master? Is the problem fixed > there already? I can't not reproduce it. -
Ioulia Kondratovitch uploaded patch set 3 10/02/18, 07:46
-
TYPO3com voted on patch set 3 V +1 10/02/18, 07:53 Completed build in 07m 16s on Tue, 2 Oct, 09:53 AM Test Summary: 59528 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3019
-
Ioulia Kondratovitch commented on patch set 3 10/02/18, 08:49
> Uploaded patch set 3. rewritten to a join. -
Joerg Kummer commented on patch set 3 V -1 10/26/18, 07:50
Tried with workspaces: this change shows also sys_templates, which belongs to workspaces only. Btw: page join statement was removed some month ago within patch #57856 -
Ioulia Kondratovitch uploaded patch set 4 11/29/18, 22:46
-
Ioulia Kondratovitch commented on patch set 4 11/29/18, 22:49
removed obsolete where-clause (covered by join already) => the patch should work now with workspaces as wellTypoScriptTemplateModuleController.php:237ReplyDone -
TYPO3com voted on patch set 4 V +1 11/29/18, 23:07 Completed build in 20m 42s on Fri, 30 Nov, 12:07 AM Test Summary: 79310 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3231
-
Joerg Kummer voted on patch set 4 V +1 CR +1 12/03/18, 11:14
-
Markus Klein voted on patch set 4 V +2 CR +2 12/05/18, 17:31
-
Markus Klein merged patch set 5 12/05/18, 17:32