Review main Merged

58474[FEATURE] Make prepending slash in TCA slug configurable

Benni Mack CR +2 V +2 Hard +238 −21 updated 09/30/18, 08:12

Commit message

A new TCA option for TCA type "slug" is added, called "prependSlash",
which adds a "/" in front of the field. For pages (pages.slug),
this is mandatory and cannot be configured, as the slug field
has to be filled and set to "/" as a base for the root page.

For other database fields, this is optional (and disabled by default),
and can be enabled via "prependSlash" in TCA config.

This option is mostly useful for recursive records, like categories,
but for most "flat" structures like "news" or "events", this is not
suitable. For pages, it is hard-coded and cannot be (un-)set.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2
    • Jigal van Hemert +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Benni Mack uploaded patch set 1 09/29/18, 19:05

  2. Benni Mack commented on patch set 1 CR -1 09/29/18, 19:05

    Feature RST still missing
  3. TYPO3com voted on patch set 1 V -1 09/29/18, 19:19 Completed build in 11m 44s on Sat, 29 Sep, 09:19 PM Test Summary: 66 of 36551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28942

  4. Benni Mack uploaded patch set 2 09/29/18, 20:40

  5. TYPO3com voted on patch set 2 V +1 09/29/18, 20:51 Completed build in 10m 26s on Sat, 29 Sep, 10:51 PM Test Summary: 36244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28959

  6. Oliver Hader voted on patch set 2 CR +1 09/29/18, 21:10

  7. Oliver Hader voted on patch set 2 V +1 09/29/18, 21:11

  8. Jörg Bösche voted on patch set 2 CR +1 09/29/18, 21:27

  9. Jigal van Hemert voted on patch set 2 V +2 CR +2 09/30/18, 08:06

  10. Benni Mack merged patch set 3 09/30/18, 08:12