Review main Merged

58477[TASK] Mark various TypoScript parsing functionality as internal

Benni Mack CR +2 V +2 Hard +253 −35 updated 09/30/18, 12:47

Commit message

The TypoScript Parser has been around since PHP 4 and hasn't
been touched much since 12ys. In order to speed up TypoScript
processing in the future, it is important to first streamline
all usages and mark internal functionality as "protected" instead
of "public".

Some other parts for sys_template rendering has been
marked as internal as well.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1116

  1. Benni Mack uploaded patch set 1 09/29/18, 22:02

  2. TYPO3com voted on patch set 1 V -1 09/29/18, 22:10 Completed build in 07m 49s on Sun, 30 Sep, 12:10 AM Test Summary: 18 of 36544 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28967

  3. Benni Mack uploaded patch set 2 09/29/18, 22:14

  4. Frank Nägler voted on patch set 2 CR +1 09/29/18, 22:27

  5. TYPO3com voted on patch set 2 V -1 09/29/18, 22:27 Completed build in 13m 16s on Sun, 30 Sep, 12:27 AM Test Summary: 12 of 36544 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28969

  6. Benni Mack uploaded patch set 3 09/29/18, 22:36

  7. TYPO3com voted on patch set 3 V +1 09/29/18, 22:47 Completed build in 10m 30s on Sun, 30 Sep, 12:47 AM Test Summary: 36208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28974

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 09/30/18, 10:46

  9. Benni Mack uploaded patch set 4 09/30/18, 11:21

  10. TYPO3com voted on patch set 4 V +1 09/30/18, 11:35 Completed build in 13m 39s on Sun, 30 Sep, 01:35 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29001

  11. Wouter Wolters voted on patch set 4 V +1 CR +1 09/30/18, 12:09

  12. Christian Kuhn commented on patch set 5 09/30/18, 12:19

    Published edit on patch set 4.
  13. Christian Kuhn voted on patch set 5 V +1 CR +1 09/30/18, 12:20

  14. TYPO3com voted on patch set 5 V +1 09/30/18, 12:44 Completed build in 21m 55s on Sun, 30 Sep, 02:44 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29013

  15. Stefan Neufeind voted on patch set 5 V +2 CR +2 09/30/18, 12:47

  16. Stefan Neufeind merged patch set 6 09/30/18, 12:47