Review main Merged

58478[FEATURE] Introduce PageTypeEnhancer

Benni Mack CR +2 V +2 Hard +497 −43 updated 09/30/18, 22:54

Commit message

A new PageTypeEnhancer is added to map the internal TYPO3
GET parameter `type` to a speaking URL suffix.

The PageTypeEnhancer only does suffixes, if other

You can configure it like this:

routeEnhancers:
  PageType:
    type: PageType
    default: ''
    map:
      '.html': 1
      'menu.json': 13

Review

  • Code review CR +2
    • Frank Nägler +2
    • Oliver Hader +1
  • Verified V +2
    • Frank Nägler +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 1831

Show 36 earlier messages
  1. Benni Mack uploaded patch set 1 09/29/18, 22:27

  2. Benni Mack updated the commit message in patch set 2 09/29/18, 22:39

  3. TYPO3com voted on patch set 1 V -1 09/29/18, 22:43 Completed build in 16m 38s on Sun, 30 Sep, 12:43 AM Test Summary: 3551 of 36568 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28973

  4. TYPO3com voted on patch set 2 V -1 09/29/18, 22:51 Completed build in 11m 34s on Sun, 30 Sep, 12:51 AM Test Summary: 3551 of 36568 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28975

  5. Benni Mack uploaded patch set 3 09/30/18, 12:23

  6. TYPO3com voted on patch set 3 V +1 09/30/18, 12:52 Completed build in 16m 45s on Sun, 30 Sep, 02:52 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29014

  1. Benni Mack uploaded patch set 4 09/30/18, 15:48

  2. TYPO3com voted on patch set 4 V +1 09/30/18, 16:00 Completed build in 12m 05s on Sun, 30 Sep, 06:00 PM Test Summary: 36880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29037

  3. Oliver Hader uploaded patch set 5 09/30/18, 17:33

  4. TYPO3com voted on patch set 5 V -1 09/30/18, 17:36 Completed build in 27s on Sun, 30 Sep, 07:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29051

  5. Oliver Hader uploaded patch set 6 09/30/18, 19:46

  6. TYPO3com voted on patch set 6 V -1 09/30/18, 19:48 Completed build in 44s on Sun, 30 Sep, 09:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29075

  7. Oliver Hader uploaded patch set 7 09/30/18, 19:48

  8. TYPO3com voted on patch set 7 V -1 09/30/18, 20:05 Completed build in 30s on Sun, 30 Sep, 10:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29078

  9. Benni Mack uploaded patch set 8 09/30/18, 20:21

  10. Benni Mack uploaded patch set 9 09/30/18, 20:22

  11. TYPO3com voted on patch set 8 V +1 09/30/18, 20:56 Completed build in 33m 47s on Sun, 30 Sep, 10:56 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29086

  12. TYPO3com voted on patch set 9 V +1 09/30/18, 20:58 Completed build in 35m 40s on Sun, 30 Sep, 10:58 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29087

  13. Oliver Hader uploaded patch set 10 09/30/18, 21:29

  14. Oliver Hader uploaded patch set 11 09/30/18, 21:30

  15. TYPO3com voted on patch set 10 V -1 09/30/18, 21:44 Completed build in 26s on Sun, 30 Sep, 11:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29099

  16. TYPO3com voted on patch set 11 V -1 09/30/18, 21:44 Completed build in 40s on Sun, 30 Sep, 11:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29100

  17. Benni Mack uploaded patch set 12 09/30/18, 21:45

  18. TYPO3com voted on patch set 12 V +1 09/30/18, 22:03 Completed build in 12m 34s on Mon, 1 Oct, 12:03 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29103

  19. Benni Mack uploaded patch set 13 09/30/18, 22:24

  20. Oliver Hader voted on patch set 13 V +1 CR +1 09/30/18, 22:27

  21. Frank Nägler voted on patch set 13 CR +1 09/30/18, 22:39

  22. TYPO3com voted on patch set 13 V +1 09/30/18, 22:40 Completed build in 12m 26s on Mon, 1 Oct, 12:40 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29110

  23. Frank Nägler voted on patch set 13 V +2 CR +2 09/30/18, 22:45

  24. Frank Nägler merged patch set 14 09/30/18, 22:45

  25. Oliver Hader commented on patch set 14 09/30/18, 22:54