58478[FEATURE] Introduce PageTypeEnhancer
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Oliver Hader +1
-
Verified V +2
- Frank Nägler +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 15
- typo3/sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php+23 −1
- typo3/sysext/core/Classes/Routing/Enhancer/DecoratingEnhancerInterface.phpnew+45 −0
- typo3/sysext/core/Classes/Routing/Enhancer/EnhancerInterface.php+3 −20
- typo3/sysext/core/Classes/Routing/Enhancer/PageTypeDecorator.phpnew+192 −0
- typo3/sysext/core/Classes/Routing/Enhancer/PluginEnhancer.php+3 −2
- typo3/sysext/core/Classes/Routing/Enhancer/RoutingEnhancerInterface.phpnew+41 −0
- typo3/sysext/core/Classes/Routing/Enhancer/SimpleEnhancer.php+3 −2
- typo3/sysext/core/Classes/Routing/PageArguments.php+20 −2
- typo3/sysext/core/Classes/Routing/PageRouter.php+67 −11
- typo3/sysext/core/Classes/Routing/Route.php+25 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-86160-PageTypeEnhancerForMappingTypeParameter.rstnew+68 −0
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php+2 −1
- typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php+3 −3
Review log 1831
Show 36 earlier messages
-
Benni Mack uploaded patch set 1 09/29/18, 22:27
-
Benni Mack updated the commit message in patch set 2 09/29/18, 22:39
-
TYPO3com voted on patch set 1 V -1 09/29/18, 22:43 Completed build in 16m 38s on Sun, 30 Sep, 12:43 AM Test Summary: 3551 of 36568 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28973
-
TYPO3com voted on patch set 2 V -1 09/29/18, 22:51 Completed build in 11m 34s on Sun, 30 Sep, 12:51 AM Test Summary: 3551 of 36568 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28975
-
Benni Mack uploaded patch set 3 09/30/18, 12:23
-
TYPO3com voted on patch set 3 V +1 09/30/18, 12:52 Completed build in 16m 45s on Sun, 30 Sep, 02:52 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29014
-
Benni Mack uploaded patch set 4 09/30/18, 15:48
-
TYPO3com voted on patch set 4 V +1 09/30/18, 16:00 Completed build in 12m 05s on Sun, 30 Sep, 06:00 PM Test Summary: 36880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29037
-
Oliver Hader uploaded patch set 5 09/30/18, 17:33
-
TYPO3com voted on patch set 5 V -1 09/30/18, 17:36 Completed build in 27s on Sun, 30 Sep, 07:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29051
-
Oliver Hader uploaded patch set 6 09/30/18, 19:46
-
TYPO3com voted on patch set 6 V -1 09/30/18, 19:48 Completed build in 44s on Sun, 30 Sep, 09:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29075
-
Oliver Hader uploaded patch set 7 09/30/18, 19:48
-
TYPO3com voted on patch set 7 V -1 09/30/18, 20:05 Completed build in 30s on Sun, 30 Sep, 10:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29078
-
Benni Mack uploaded patch set 8 09/30/18, 20:21
-
Benni Mack uploaded patch set 9 09/30/18, 20:22
-
TYPO3com voted on patch set 8 V +1 09/30/18, 20:56 Completed build in 33m 47s on Sun, 30 Sep, 10:56 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29086
-
TYPO3com voted on patch set 9 V +1 09/30/18, 20:58 Completed build in 35m 40s on Sun, 30 Sep, 10:58 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29087
-
Oliver Hader uploaded patch set 10 09/30/18, 21:29
-
Oliver Hader uploaded patch set 11 09/30/18, 21:30
-
TYPO3com voted on patch set 10 V -1 09/30/18, 21:44 Completed build in 26s on Sun, 30 Sep, 11:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29099
-
TYPO3com voted on patch set 11 V -1 09/30/18, 21:44 Completed build in 40s on Sun, 30 Sep, 11:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29100
-
Benni Mack uploaded patch set 12 09/30/18, 21:45
-
TYPO3com voted on patch set 12 V +1 09/30/18, 22:03 Completed build in 12m 34s on Mon, 1 Oct, 12:03 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29103
-
Benni Mack uploaded patch set 13 09/30/18, 22:24
-
Oliver Hader voted on patch set 13 V +1 CR +1 09/30/18, 22:27
-
Frank Nägler voted on patch set 13 CR +1 09/30/18, 22:39
-
TYPO3com voted on patch set 13 V +1 09/30/18, 22:40 Completed build in 12m 26s on Mon, 1 Oct, 12:40 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29110
-
Frank Nägler voted on patch set 13 V +2 CR +2 09/30/18, 22:45
-
Frank Nägler merged patch set 14 09/30/18, 22:45
-
Oliver Hader commented on patch set 14 09/30/18, 22:54
Follow-up: https://review.typo3.org/#/c/58512/