Review main Merged

58480[BUGFIX] EvaluteDisplayCondition should throw proper error message

Benni Mack CR +2 V +2 Easy +23 −1 updated 10/27/18, 17:41

Commit message

When an extension author writes a display condition in TCA and
by incident uses a wrong format for the displayCondition (see ticket)
the strtoupper fails due to the lack of an associative array
because it's a numeric-key array.

An additional check fixes the issue.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Christian Kuhn +1
  • Verified V +2
    • Jigal van Hemert +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 09/29/18, 23:42

  2. TYPO3com voted on patch set 1 V +1 09/29/18, 23:53 Completed build in 10m 34s on Sun, 30 Sep, 01:53 AM Test Summary: 36211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28977

  3. Christian Kuhn updated the commit message in patch set 2 09/30/18, 09:48

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 09/30/18, 09:49

  5. TYPO3com voted on patch set 2 V +1 09/30/18, 09:59 Completed build in 10m 46s on Sun, 30 Sep, 11:59 AM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28986

  6. Jigal van Hemert voted on patch set 2 V +2 CR +2 09/30/18, 10:25

  7. Jigal van Hemert merged patch set 3 09/30/18, 10:25

  8. Stephan Großberndt commented on patch set 3 10/27/18, 15:29

    Backport to 8.7 is missing
  9. Jigal van Hemert commented on patch set 3 10/27/18, 17:41

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8e37bb3391484951de03438df2a306443f22591b