58481[TASK] Reintroduce tooltips for new SVG Pagetree
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Josef Glatz +1
- Susi Moog +1
-
Verified V +2
- Frank Nägler +2
- Riccardo De Contardi +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2328
Show 23 earlier messages
-
Nikita Hovratov uploaded patch set 1 09/30/18, 00:07
-
TYPO3com voted on patch set 1 V +1 09/30/18, 00:16 Completed build in 09m 18s on Sun, 30 Sep, 02:16 AM Test Summary: 36208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28978
-
Josef Glatz commented on patch set 1 V -1 CR -1 09/30/18, 05:39
To show the tooltip on hovering anywhere on a page is a nice idea.But I think that this is a breaking change from the UX point of view. If the others decide that the tooltip will be from now on displayed while hovering anywhere on the pagetree element, then the positioning needs to be adjusted => The tooltip is horizontally centered which makes the tooltip appearing once there and once there, if you create a page with a looong title (where the text goes beyond the right pagetree frame edge) As a first step I would strongly decide to add the behaviour like before: - tooltip only on hovering the page icon - data-placement="right" for the icon
-
Björn Jacob commented on patch set 1 CR +1 09/30/18, 08:05
I am also for just bringing back the old behaviour (as it can be seen in the list module). No improvements for v9 please. Keep the UI consistent. -
Nikita Hovratov uploaded patch set 2 09/30/18, 12:12
-
Nikita Hovratov commented on patch set 2 09/30/18, 12:24
Thank you for your feedback! And you are right, i adjusted the tooltip now like it was in v8. Please have a look at it. -
Nikita Hovratov updated the commit message in patch set 3 09/30/18, 12:27
-
TYPO3com voted on patch set 2 V +1 09/30/18, 12:31 Completed build in 17m 38s on Sun, 30 Sep, 02:31 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29010
-
TYPO3com voted on patch set 3 V +1 09/30/18, 12:57 Completed build in 22m 40s on Sun, 30 Sep, 02:57 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29016
-
Guido Schmechel voted on patch set 3 V +1 09/30/18, 12:59
-
Tymoteusz Motylewski commented on patch set 3 09/30/18, 13:06
Have you investigated simce which commit is it broken? -
Nikita Hovratov commented on patch set 3 09/30/18, 13:07
> Patch Set 3: > > Have you investigated simce which commit is it broken? It was not broken, just not implemented. -
Riccardo De Contardi voted on patch set 3 V +1 09/30/18, 14:10
-
Josef Glatz updated the commit message in patch set 4 09/30/18, 16:38
-
Josef Glatz commented on patch set 4 V +1 CR +1 09/30/18, 16:38
Thanks Nikita -
Josef Glatz commented on patch set 4 V -1 CR -1 09/30/18, 16:40
Found an issue, will try to formulate the bug -
TYPO3com voted on patch set 4 V +1 09/30/18, 16:47 Completed build in 09m 36s on Sun, 30 Sep, 06:47 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29046
-
Josef Glatz commented on patch set 4 09/30/18, 16:54
I've created an animated gif to show the existing troubles. https://forge.typo3.org/issues/86314#note-6 -
Nikita Hovratov commented on patch set 4 09/30/18, 17:13
Seems to be only happening in chrome -
Nikita Hovratov uploaded patch set 5 09/30/18, 18:11
-
Nikita Hovratov commented on patch set 5 09/30/18, 18:13
I had to add a scroll event for the pagetree, honestly i don't know why chrome behaves likes this and doesn't trigger the mouseout event when scrolling. -
TYPO3com voted on patch set 5 V +1 09/30/18, 18:23 Completed build in 11m 43s on Sun, 30 Sep, 08:23 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29057
-
Riccardo De Contardi commented on patch set 5 V +1 09/30/18, 19:10
seems fine even with scrolling the tree (Chrome) -
Susi Moog voted on patch set 5 V +1 09/30/18, 20:48
-
Frank Nägler voted on patch set 5 V +2 CR +2 09/30/18, 20:58
-
Josef Glatz voted on patch set 5 CR +1 09/30/18, 20:59
-
Susi Moog voted on patch set 5 CR +1 09/30/18, 20:59
-
Frank Nägler merged patch set 6 09/30/18, 20:59