Review main Merged

58482[TASK] Remove leftover .htaccess files in Resources/Private folders

Josef Glatz CR +2 V +2 Normal +0 −88 updated 09/30/18, 11:10

Commit message

Leftover .htaccess files were savedly removed, as the root
.htaccess (for Apache webserver) / .web.config (for IIS webserver)
already takes care of access rules.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Jigal van Hemert +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 910

  1. Josef Glatz uploaded patch set 1 09/30/18, 06:27

  2. Josef Glatz wrote 09/30/18, 06:27

    Assignee added: Georg Ringer <georg.ringer@gmail.com>
  3. Josef Glatz commented on patch set 1 09/30/18, 06:36

    We have 2 options: a) remove them (as mentioned in commit) b) add .htaccess to EVERY sysext with Private folder
  4. Josef Glatz wrote 09/30/18, 06:36

    Assignee deleted: Georg Ringer <georg.ringer@gmail.com>
  5. TYPO3com voted on patch set 1 V +1 09/30/18, 06:37 Completed build in 09m 56s on Sun, 30 Sep, 08:37 AM Test Summary: 36208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28980

  6. Benni Mack voted on patch set 1 CR +1 09/30/18, 10:04

  7. Jigal van Hemert voted on patch set 1 V +1 CR +1 09/30/18, 10:28

  8. Wouter Wolters voted on patch set 1 CR +1 09/30/18, 10:30

  9. Christian Kuhn voted on patch set 1 V +2 CR +2 09/30/18, 11:10

  10. Christian Kuhn merged patch set 2 09/30/18, 11:10