Review main Merged

58485[TASK] Deprecate AbstractUserAuthentication->fetchUserRecord

Christian Kuhn CR +2 V +2 Normal +76 −2 updated 09/30/18, 11:13

Commit message

To untie authentication services from user authentication a bit better,
the fetchUserRecord() method of AbstractAuthenticationService now
implements fetchUserRecord() on its own instead of calling the method
with the same name of $pObj.
AbstractUserAuthentication->fetchUserRecord() is then unused and can
be deprecated.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Christian Kuhn uploaded patch set 1 09/30/18, 10:37

  2. TYPO3com voted on patch set 1 V +1 09/30/18, 10:46 Completed build in 08m 36s on Sun, 30 Sep, 12:46 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28993

  3. Wouter Wolters commented on patch set 1 CR +1 09/30/18, 10:48

    Deprecation-86466-AbstractUserAuthentication-fetchUserRecord.rst:12

    ->
  4. Christian Kuhn commented on patch set 2 09/30/18, 10:50

    Published edit on patch set 1.
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 09/30/18, 10:55

  6. TYPO3com voted on patch set 2 V +1 09/30/18, 11:00 Completed build in 09m 57s on Sun, 30 Sep, 01:00 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-28994

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/30/18, 11:13

  8. Anja Leichsenring merged patch set 3 09/30/18, 11:13