Review main Merged

58493[BUGFIX] Minor adjustments to wordings, variables and docs

Benni Mack CR +2 V +2 Easy +3 −3 updated 09/30/18, 12:24

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1012

  1. Benni Mack uploaded patch set 1 09/30/18, 11:57

  2. Christian Kuhn commented on patch set 1 09/30/18, 11:59

    SystemEnvironmentBuilder.php:187

    int $entryPointLevel should be do-able without problems here.
  3. Christian Kuhn commented on patch set 2 09/30/18, 12:05

    Published edit on patch set 1.
  4. Christian Kuhn voted on patch set 2 CR +1 09/30/18, 12:06

  5. TYPO3com voted on patch set 1 V +1 09/30/18, 12:07 Completed build in 09m 31s on Sun, 30 Sep, 02:07 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29005

  6. Wouter Wolters voted on patch set 2 CR +1 09/30/18, 12:10

  7. TYPO3com voted on patch set 2 V +1 09/30/18, 12:18 Completed build in 12m 30s on Sun, 30 Sep, 02:18 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29007

  8. Christian Kuhn voted on patch set 2 V +1 09/30/18, 12:20

  9. Stefan Neufeind voted on patch set 2 V +1 CR +1 09/30/18, 12:23

  10. Benni Mack voted on patch set 2 V +2 CR +2 09/30/18, 12:24

  11. Benni Mack merged patch set 3 09/30/18, 12:24

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 09/30/18, 12:24