Review main Merged

58494[BUGFIX] Streamline trigger_error messages

Benni Mack CR +2 V +2 Expert +1244 −1256 updated 09/30/18, 22:15

Commit message

This patch streamlines all deprecation messages and follow the
following rules.

1. All @deprecated should contain
@deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10"

2. trigger_error()
- All trigger_error() messages MUST end with a "." (dot).
- Never use "This method" but the method name (enjoy the logs otherwise)
- "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file.
- Do not use "__METHOD__" or some other "magic".

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 196

Show 176 more files

Review log 69

  1. Benni Mack uploaded patch set 1 09/30/18, 12:03

  2. TYPO3com voted on patch set 1 V +1 09/30/18, 12:16 Completed build in 12m 32s on Sun, 30 Sep, 02:16 PM Test Summary: 36559 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29006

  3. Benni Mack uploaded patch set 2 09/30/18, 19:47

  4. TYPO3com voted on patch set 2 V +1 09/30/18, 20:15 Completed build in 27m 49s on Sun, 30 Sep, 10:15 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29076

  5. Benni Mack uploaded patch set 3 09/30/18, 21:44

  6. Wouter Wolters voted on patch set 3 V +1 CR +1 09/30/18, 21:58

  7. Frank Nägler commented on patch set 3 V +2 CR +2 09/30/18, 21:59

    thx man, very awesome... lets wait for bamboo
  8. TYPO3com voted on patch set 3 V +1 09/30/18, 22:12 Completed build in 21m 38s on Mon, 1 Oct, 12:12 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29102

  9. Frank Nägler merged patch set 4 09/30/18, 22:15