Review main Merged

58496[TASK] Avoid count() in test conditions

Christian Kuhn CR +2 V +2 Easy +6 −3 updated 09/30/18, 13:59

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Christian Kuhn uploaded patch set 1 09/30/18, 13:16

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 09/30/18, 13:21

  3. Stefan Neufeind commented on patch set 1 CR -1 09/30/18, 13:26

    another one is in: typo3/sysext/core/Resources/PHP/ClassMapGenerator.php
  4. TYPO3com voted on patch set 1 V +1 09/30/18, 13:27 Completed build in 10m 53s on Sun, 30 Sep, 03:27 PM Test Summary: 36874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29021

  5. Stefan Neufeind uploaded patch set 2 09/30/18, 13:29

  6. Stefan Neufeind voted on patch set 2 CR +1 09/30/18, 13:29

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 09/30/18, 13:31

  8. TYPO3com voted on patch set 2 V +1 09/30/18, 13:50 Completed build in 13m 22s on Sun, 30 Sep, 03:50 PM Test Summary: 36874 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29026

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/30/18, 13:59

  10. Anja Leichsenring merged patch set 3 09/30/18, 13:59