Review main Merged

58502[BUGFIX] Ensure workspace preview works with Site Handling

Benni Mack CR +2 V +2 Normal +65 −24 updated 09/30/18, 17:26

Commit message

While introducing Page URL handling, the workspace functionality
still built the URL with `/index.php` although the Router should
take care of that now.

As drive-by fix, the BackendUtility preview URL hook now works again
due to some refactoring back in TYPO3 9.2.

Another drive-by fix allows to register the middleware at the
right place to render the workspace preview in general.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Frank Nägler +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 710

  1. Benni Mack uploaded patch set 1 09/30/18, 15:23

  2. TYPO3com voted on patch set 1 V -1 09/30/18, 15:32 Completed build in 09m 31s on Sun, 30 Sep, 05:32 PM Test Summary: 36880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29034

  3. TYPO3com commented on patch set 1 09/30/18, 15:49 Completed build in 35m 44s on Sun, 30 Sep, 05:49 PM Test Summary: 36880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29034

  4. Oliver Hader commented on patch set 2 09/30/18, 15:53

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 09/30/18, 16:03 Completed build in 10m 06s on Sun, 30 Sep, 06:03 PM Test Summary: 36880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29038

  6. Frank Nägler voted on patch set 2 CR +1 09/30/18, 16:15

  7. Frank Nägler voted on patch set 2 V +1 09/30/18, 16:40

  8. Daniel Goerz voted on patch set 2 V +1 CR +1 09/30/18, 16:56

  9. Benni Mack voted on patch set 2 V +2 CR +2 09/30/18, 17:26

  10. Benni Mack merged patch set 3 09/30/18, 17:26