58505[TASK] Improve code to avoid Scrutinizer warnings
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Stefan Neufeind +1
- Stephan Großberndt +1
- Jan Stockfisch +1
- Benni Mack +1
-
Verified V +2
- Benni Mack +2
- Andreas Wolf +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+4 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php2+6 −2
Review log 1519
-
Markus Klein uploaded patch set 1 09/30/18, 16:23
-
TYPO3com voted on patch set 1 V -1 09/30/18, 16:24 Completed build in 13s on Sun, 30 Sep, 06:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29042
-
Markus Klein uploaded patch set 2 09/30/18, 16:26
-
TYPO3com voted on patch set 2 V -1 09/30/18, 16:26 Completed build in 10s on Sun, 30 Sep, 06:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29043
-
Markus Klein uploaded patch set 3 09/30/18, 16:30
-
Stephan Großberndt voted on patch set 3 CR +1 09/30/18, 16:33
-
TYPO3com voted on patch set 3 V +1 09/30/18, 16:41 Completed build in 11m 01s on Sun, 30 Sep, 06:41 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29045
-
Tymoteusz Motylewski commented on patch set 3 09/30/18, 17:24
-
Markus Klein commented on patch set 3 09/30/18, 17:59
LazyLoadingProxy.php:75ReplyFine with me, I prefer the former version anyways. -
Markus Klein commented on patch set 4 09/30/18, 18:00
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 09/30/18, 18:12 Completed build in 12m 43s on Sun, 30 Sep, 08:12 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29055
-
Benni Mack voted on patch set 4 CR +1 09/30/18, 19:14
-
Stephan Großberndt voted on patch set 4 CR +1 10/01/18, 05:22
-
Stefan Neufeind voted on patch set 4 CR +1 10/01/18, 07:23
-
Jan Stockfisch voted on patch set 4 CR +1 10/01/18, 09:17
-
Andreas Wolf commented on patch set 4 CR +2 10/01/18, 10:18
Going to test this now by applying and trying if Extbase persistence still works. -
Andreas Wolf voted on patch set 4 V +1 10/01/18, 10:41
-
Benni Mack voted on patch set 4 V +2 10/01/18, 13:34
-
Benni Mack merged patch set 5 10/01/18, 13:34
LazyLoadingProxy.php:75