Review main Merged

58506[BUGFIX] Installer should use 50% of its space

Benni Mack CR +2 V +2 Normal +89 −87 updated 09/30/18, 18:45

Commit message

The Installer uses a full grid which is a lot of white space if not needed.

So, the whole layout is put into a col-md-6 grid with a col-md-offset-3
offset.

Review

  • Code review CR +2
    • Susi Moog +2
    • Frank Nägler +1
  • Verified V +2
    • Susi Moog +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1115

  1. Benni Mack uploaded patch set 1 09/30/18, 16:52

  2. Frank Nägler commented on patch set 1 CR -1 09/30/18, 16:55

    on it
  3. TYPO3com voted on patch set 1 V +1 09/30/18, 17:02 Completed build in 09m 58s on Sun, 30 Sep, 07:02 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29047

  4. Frank Nägler uploaded patch set 2 09/30/18, 17:25

  5. Frank Nägler uploaded patch set 3 09/30/18, 17:30

  6. Frank Nägler voted on patch set 3 V +1 CR +1 09/30/18, 17:30

  7. TYPO3com voted on patch set 2 V +1 09/30/18, 17:37 Completed build in 12m 33s on Sun, 30 Sep, 07:37 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29048

  8. TYPO3com voted on patch set 3 V +1 09/30/18, 17:44 Completed build in 13m 47s on Sun, 30 Sep, 07:44 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29050

  9. Wouter Wolters voted on patch set 3 CR +1 09/30/18, 18:26

  10. Susi Moog uploaded patch set 4 09/30/18, 18:28

  11. Susi Moog commented on patch set 4 09/30/18, 18:28

    reverted the big progress bar part as that broke the layout of step 1.
  12. Frank Nägler commented on patch set 4 V +1 CR +1 09/30/18, 18:29

    thx! I am fine
  13. TYPO3com voted on patch set 4 V +1 09/30/18, 18:36 Completed build in 08m 12s on Sun, 30 Sep, 08:36 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29058

  14. Susi Moog voted on patch set 4 V +2 CR +2 09/30/18, 18:45

  15. Susi Moog merged patch set 5 09/30/18, 18:45