Review main Merged

58507[TASK] Streamline Page Argument merge strategies

Benni Mack CR +2 V +2 Easy +15 −15 updated 09/30/18, 18:58

Commit message

PageArguments are fetched and added on top of PSR-7 request
queryParams right after they are validated from the PageRouter.

They are also re-populated after config.defaultGetVars has
modified global state.

But they do not need to be set to TSFE again within the
the PageArgumentValidator middleware.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Benni Mack uploaded patch set 1 09/30/18, 17:36

  2. TYPO3com voted on patch set 1 V +1 09/30/18, 17:49 Completed build in 13m 13s on Sun, 30 Sep, 07:49 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29052

  3. Susi Moog voted on patch set 1 CR +1 09/30/18, 17:55

  4. Susi Moog voted on patch set 1 V +1 09/30/18, 18:13

  5. Frank Nägler voted on patch set 1 V +2 CR +2 09/30/18, 18:58

  6. Frank Nägler merged patch set 2 09/30/18, 18:58