58512[BUGFIX] Resolve slashed values in PageTypeDecorator correctly
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Jurian Janssen +1
- Benni Mack +1
-
Verified V +2
- Susi Moog +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php+9 −9
- typo3/sysext/core/Classes/Routing/Enhancer/DecoratingEnhancerInterface.php+23 −11
- typo3/sysext/core/Classes/Routing/Enhancer/PageTypeDecorator.php+74 −30
- typo3/sysext/core/Classes/Routing/PageRouter.php2+60 −21
- typo3/sysext/core/Classes/Routing/PageUriMatcher.php+17 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-86160-PageTypeEnhancerForMappingTypeParameter.rst+23 −8
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkHandlingController.php+1 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/LinkRequest.typoscript+5 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php2+189 −29
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php+176 −32
Review log 2438
Show 713 earlier messages
-
Oliver Hader uploaded patch set 1 09/30/18, 22:53
-
TYPO3com voted on patch set 1 V +1 09/30/18, 23:03 Completed build in 09m 56s on Mon, 1 Oct, 01:03 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29112
-
Oliver Hader uploaded patch set 2 10/01/18, 07:12
-
TYPO3com voted on patch set 2 V +1 10/01/18, 07:22 Completed build in 09m 55s on Mon, 1 Oct, 09:22 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29115
-
Oliver Hader uploaded patch set 3 10/01/18, 08:14
-
TYPO3com voted on patch set 3 V +1 10/01/18, 08:25 Completed build in 11m 12s on Mon, 1 Oct, 10:25 AM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29118
-
Oliver Hader uploaded patch set 4 10/01/18, 10:04
-
TYPO3com voted on patch set 4 V +1 10/01/18, 10:14 Completed build in 10m 20s on Mon, 1 Oct, 12:14 PM Test Summary: 37345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29124
-
Oliver Hader uploaded patch set 5 10/01/18, 11:58
-
Oliver Hader rebased onto patch set 6 10/01/18, 11:58
-
Oliver Hader uploaded patch set 7 10/01/18, 12:05
-
TYPO3com voted on patch set 5 V +1 10/01/18, 12:18 Completed build in 14m 40s on Mon, 1 Oct, 02:18 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29145
-
TYPO3com voted on patch set 6 V +1 10/01/18, 12:22 Completed build in 18m 37s on Mon, 1 Oct, 02:22 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29146
-
TYPO3com voted on patch set 7 V +1 10/01/18, 12:28 Completed build in 15m 23s on Mon, 1 Oct, 02:28 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29148
-
Markus Klein commented on patch set 7 10/01/18, 12:35
causePageRouter.php:399empty()EnhancerLinkGeneratorTest.php:220this can be a string and the phpdoc does not mention the null value. however the function only copes with an array. should that be cleaned up? -
Oliver Hader commented on patch set 7 10/01/18, 12:46
PageRouter.php:399ReplyNope, should be === 1EnhancerLinkGeneratorTest.php:220ReplyIt's a test-case... PhpUnit is calling it with a string, internal custom processing with array -
Oliver Hader commented on patch set 7 CR -1 10/01/18, 12:53
on it -
Oliver Hader uploaded patch set 8 10/01/18, 12:56
-
Benni Mack voted on patch set 8 V +1 CR +1 10/01/18, 13:23
-
TYPO3com voted on patch set 8 V +1 10/01/18, 13:56 Completed build in 52m 44s on Mon, 1 Oct, 03:56 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29167
-
Oliver Hader commented on patch set 8 CR -1 10/01/18, 14:39
Investigating report on root-page -
Oliver Hader uploaded patch set 9 10/01/18, 15:35
-
Oliver Hader uploaded patch set 10 10/01/18, 15:45
-
TYPO3com voted on patch set 9 V -1 10/01/18, 15:46 Completed build in 10m 57s on Mon, 1 Oct, 05:46 PM Test Summary: 549 of 38137 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29192
-
TYPO3com voted on patch set 10 V -1 10/01/18, 15:57 Completed build in 11m 43s on Mon, 1 Oct, 05:57 PM Test Summary: 405 of 38137 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29194
-
Oliver Hader uploaded patch set 11 10/01/18, 16:39
-
TYPO3com voted on patch set 11 V -1 10/01/18, 16:51 Completed build in 12m 34s on Mon, 1 Oct, 06:51 PM Test Summary: 405 of 38137 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29198
-
Oliver Hader uploaded patch set 12 10/01/18, 16:55
-
TYPO3com voted on patch set 12 V +1 10/01/18, 17:08 Completed build in 13m 07s on Mon, 1 Oct, 07:08 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29203
-
Oliver Hader uploaded patch set 13 10/01/18, 17:12
-
TYPO3com voted on patch set 13 V +1 10/01/18, 17:26 Completed build in 13m 53s on Mon, 1 Oct, 07:26 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29207
-
Benni Mack commented on patch set 14 10/01/18, 17:51
Published edit on patch set 13. -
Benni Mack voted on patch set 14 V +1 CR +1 10/01/18, 17:51
-
TYPO3com voted on patch set 14 V +1 10/01/18, 18:04 Completed build in 12m 39s on Mon, 1 Oct, 08:04 PM Test Summary: 37777 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29212
-
Susi Moog voted on patch set 14 V +2 CR +2 10/01/18, 18:20
-
Susi Moog merged patch set 15 10/01/18, 18:20
-
Jurian Janssen voted on patch set 15 CR +1 10/01/18, 18:29