58517Revert "[FEATURE] Add stdWrap to config.additionalHeaders"
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Josef Glatz +1
- Mathias Brodala +1
- Benjamin Franzke +1
-
Verified V +2
- Markus Klein +2
- Mathias Brodala +1
- Benjamin Franzke +1
Issues 1
Files 4
- typo3/sysext/core/Documentation/Changelog/9.0/Feature-23494-AddStdWrapToConfigadditionalHeaders.rstdeleted+0 −27
- typo3/sysext/core/Documentation/Changelog/master/Breaking-86492-RemovedStdWrapSupportForConfigadditionalHeaders.rst2new+35 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php4+3 −16
- typo3/sysext/t3editor/Resources/Private/tsref.xml2+3 −3
Review log 2333
Show 58 earlier messages
-
Markus Klein uploaded patch set 1 10/01/18, 09:37
-
TYPO3com voted on patch set 1 V -1 10/01/18, 09:39 Completed build in 14s on Mon, 1 Oct, 11:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29123
-
Markus Klein commented on patch set 1 CR -1 10/01/18, 09:45
taking care -
Markus Klein uploaded patch set 2 10/01/18, 11:12
-
Markus Klein uploaded patch set 3 10/01/18, 11:21
-
TYPO3com voted on patch set 2 V +1 10/01/18, 11:24 Completed build in 11m 45s on Mon, 1 Oct, 01:24 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29133
-
Markus Klein commented on patch set 3 CR -1 10/01/18, 11:26
will add an important.rst file -
TYPO3com voted on patch set 3 V +1 10/01/18, 11:37 Completed build in 13m 48s on Mon, 1 Oct, 01:37 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29136
-
Markus Klein uploaded patch set 4 10/01/18, 11:43
-
Benjamin Franzke commented on patch set 4 CR -1 10/01/18, 11:54
TypoScriptFrontendController.php:5030?? inside instead of outside braces.TypoScriptFrontendController.php:5038casting to (int) has stronger binding than ??, leading to Undefined index notice. -
Benjamin Franzke uploaded patch set 5 10/01/18, 11:54
-
Benjamin Franzke commented on patch set 5 V +1 CR +1 10/01/18, 11:58
TypoScriptFrontendController.php:5030ReplyDoneTypoScriptFrontendController.php:5038ReplyDonetsref.xml:7102what's the reason for the indentation here? -
TYPO3com voted on patch set 4 V +1 10/01/18, 12:08 Completed build in 13m 27s on Mon, 1 Oct, 02:08 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29143
-
TYPO3com voted on patch set 5 V +1 10/01/18, 12:13 Completed build in 18m 17s on Mon, 1 Oct, 02:13 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29144
-
Markus Klein commented on patch set 4 10/01/18, 12:13
tsref.xml:7102Reply Unresolvedreformat issue in phpstorm ;-) -
Markus Klein commented on patch set 6 10/01/18, 12:14
Published edit on patch set 5. -
Mathias Brodala commented on patch set 6 CR -1 10/01/18, 12:22
On it. -
Mathias Brodala commented on patch set 7 10/01/18, 12:27
Published edit on patch set 6. -
Andreas Wolf commented on patch set 7 CR +1 10/01/18, 12:31
Looks good apart from one documentation issue.Breaking-86492-RemovedStdWrapSupportForConfigadditionalHeaders.rst:24I find that mildly confusing – the instance is only affected if this was actually used, right? -
Mathias Brodala commented on patch set 7 10/01/18, 12:45
Breaking-86492-RemovedStdWrapSupportForConfigadditionalHeaders.rst:24ReplyAbsolutely correct, yes. I'll rephrase that. -
TYPO3com voted on patch set 6 V +1 10/01/18, 12:45 Completed build in 22m 50s on Mon, 1 Oct, 02:45 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29152
-
Mathias Brodala commented on patch set 8 10/01/18, 12:46
Published edit on patch set 7. -
Mathias Brodala commented on patch set 9 10/01/18, 12:48
Published edit on patch set 8. -
TYPO3com voted on patch set 7 V +1 10/01/18, 12:51 Completed build in 14m 55s on Mon, 1 Oct, 02:51 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29153
-
Markus Klein commented on patch set 10 10/01/18, 12:51
Published edit on patch set 9. -
Mathias Brodala voted on patch set 10 V +1 CR +1 10/01/18, 12:54
-
Benjamin Franzke voted on patch set 10 V +1 CR +1 10/01/18, 13:09
-
Josef Glatz voted on patch set 10 CR +1 10/01/18, 13:13
-
TYPO3com voted on patch set 9 V +1 10/01/18, 13:34 Completed build in 30m 28s on Mon, 1 Oct, 03:34 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29164
-
Markus Klein voted on patch set 10 V +2 CR +2 10/01/18, 13:34
-
Markus Klein merged patch set 11 10/01/18, 13:34
-
TYPO3com voted on patch set 8 V +1 10/01/18, 13:39 Completed build in 35m 59s on Mon, 1 Oct, 03:39 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29163
-
TYPO3com voted on patch set 10 V +1 10/01/18, 13:43 Completed build in 39m 52s on Mon, 1 Oct, 03:43 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29165