Review main Merged

58517Revert "[FEATURE] Add stdWrap to config.additionalHeaders"

Markus Klein CR +2 V +2 Normal +41 −46 updated 10/01/18, 13:43

Commit message

This reverts commit 2124bba49f68f5c35705c5c499abe6a0ee95a6cf.

The feature is reverted as the functionality can't be provided
in a fully working manner to work in all possible cases the FE
may be called.

Review

  • Code review CR +2
    • Markus Klein +2
    • Josef Glatz +1
    • Mathias Brodala +1
    • Benjamin Franzke +1
  • Verified V +2
    • Markus Klein +2
    • Mathias Brodala +1
    • Benjamin Franzke +1

Issues 1

Files 4

Review log 2333

Show 58 earlier messages
  1. Markus Klein uploaded patch set 1 10/01/18, 09:37

  2. TYPO3com voted on patch set 1 V -1 10/01/18, 09:39 Completed build in 14s on Mon, 1 Oct, 11:39 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29123

  3. Markus Klein commented on patch set 1 CR -1 10/01/18, 09:45

    taking care
  4. Markus Klein uploaded patch set 2 10/01/18, 11:12

  5. Markus Klein uploaded patch set 3 10/01/18, 11:21

  6. TYPO3com voted on patch set 2 V +1 10/01/18, 11:24 Completed build in 11m 45s on Mon, 1 Oct, 01:24 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29133

  7. Markus Klein commented on patch set 3 CR -1 10/01/18, 11:26

    will add an important.rst file
  8. TYPO3com voted on patch set 3 V +1 10/01/18, 11:37 Completed build in 13m 48s on Mon, 1 Oct, 01:37 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29136

  1. Markus Klein uploaded patch set 4 10/01/18, 11:43

  2. Benjamin Franzke commented on patch set 4 CR -1 10/01/18, 11:54

    TypoScriptFrontendController.php:5030

    ?? inside instead of outside braces.

    TypoScriptFrontendController.php:5038

    casting to (int) has stronger binding than ??, leading to Undefined index notice.
  3. Benjamin Franzke uploaded patch set 5 10/01/18, 11:54

  4. Benjamin Franzke commented on patch set 5 V +1 CR +1 10/01/18, 11:58

    TypoScriptFrontendController.php:5030 Reply

    Done

    TypoScriptFrontendController.php:5038 Reply

    Done

    tsref.xml:7102

    what's the reason for the indentation here?
  5. TYPO3com voted on patch set 4 V +1 10/01/18, 12:08 Completed build in 13m 27s on Mon, 1 Oct, 02:08 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29143

  6. TYPO3com voted on patch set 5 V +1 10/01/18, 12:13 Completed build in 18m 17s on Mon, 1 Oct, 02:13 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29144

  7. Markus Klein commented on patch set 4 10/01/18, 12:13

    tsref.xml:7102 Reply Unresolved

    reformat issue in phpstorm ;-)
  8. Markus Klein commented on patch set 6 10/01/18, 12:14

    Published edit on patch set 5.
  9. Mathias Brodala commented on patch set 6 CR -1 10/01/18, 12:22

    On it.
  10. Mathias Brodala commented on patch set 7 10/01/18, 12:27

    Published edit on patch set 6.
  11. Andreas Wolf commented on patch set 7 CR +1 10/01/18, 12:31

    Looks good apart from one documentation issue.

    Breaking-86492-RemovedStdWrapSupportForConfigadditionalHeaders.rst:24

    I find that mildly confusing – the instance is only affected if this was actually used, right?
  12. Mathias Brodala commented on patch set 7 10/01/18, 12:45

    Breaking-86492-RemovedStdWrapSupportForConfigadditionalHeaders.rst:24 Reply

    Absolutely correct, yes. I'll rephrase that.
  13. TYPO3com voted on patch set 6 V +1 10/01/18, 12:45 Completed build in 22m 50s on Mon, 1 Oct, 02:45 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29152

  14. Mathias Brodala commented on patch set 8 10/01/18, 12:46

    Published edit on patch set 7.
  15. Mathias Brodala commented on patch set 9 10/01/18, 12:48

    Published edit on patch set 8.
  16. TYPO3com voted on patch set 7 V +1 10/01/18, 12:51 Completed build in 14m 55s on Mon, 1 Oct, 02:51 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29153

  17. Markus Klein commented on patch set 10 10/01/18, 12:51

    Published edit on patch set 9.
  18. Mathias Brodala voted on patch set 10 V +1 CR +1 10/01/18, 12:54

  19. Benjamin Franzke voted on patch set 10 V +1 CR +1 10/01/18, 13:09

  20. Josef Glatz voted on patch set 10 CR +1 10/01/18, 13:13

  21. TYPO3com voted on patch set 9 V +1 10/01/18, 13:34 Completed build in 30m 28s on Mon, 1 Oct, 03:34 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29164

  22. Markus Klein voted on patch set 10 V +2 CR +2 10/01/18, 13:34

  23. Markus Klein merged patch set 11 10/01/18, 13:34

  24. TYPO3com voted on patch set 8 V +1 10/01/18, 13:39 Completed build in 35m 59s on Mon, 1 Oct, 03:39 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29163

  25. TYPO3com voted on patch set 10 V +1 10/01/18, 13:43 Completed build in 39m 52s on Mon, 1 Oct, 03:43 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29165