Review main Merged

58519[TASK] Add proper exception handling to RouterInterface logic

Benni Mack CR +2 V +2 Normal +90 −22 updated 10/01/18, 13:39

Commit message

Two new Exceptions are now thrown when routing does not
work, one being thrown when a URL is generated but could
not be generated, and one when a URL could not be resolved.

This is much cleaner than the distinction of a nullable return type,
so the new interface is adapted as well.

As a drive-by fix, the Backend routing exception now inherits from
this new exception.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Oliver Hader +1
  • Verified V +2
    • Susi Moog +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 1416

  1. Benni Mack uploaded patch set 1 10/01/18, 10:42

  2. TYPO3com voted on patch set 1 V +1 10/01/18, 10:55 Completed build in 12m 11s on Mon, 1 Oct, 12:55 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29131

  3. Mathias Brodala commented on patch set 1 10/01/18, 10:55

    PageLinkBuilder.php:374

    Since this ends up as debug log entry can we append the exception message here?
  4. Benni Mack commented on patch set 2 10/01/18, 11:08

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 10/01/18, 11:18 Completed build in 09m 58s on Mon, 1 Oct, 01:18 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29132

  6. Wouter Wolters voted on patch set 2 CR +1 10/01/18, 11:28

  7. Oliver Hader voted on patch set 2 CR +1 10/01/18, 12:44

  8. Oliver Hader voted on patch set 2 V +1 10/01/18, 13:13

  9. Markus Klein commented on patch set 2 CR -1 10/01/18, 13:13

    reviewing
  10. Markus Klein voted on patch set 2 CR +1 10/01/18, 13:21

  11. Oliver Hader commented on patch set 2 10/01/18, 13:26

    PageRouter.php:269

    Thanks! This was important since otherwise it lead to a PHP error since the strict return type did not match! +1
  12. Markus Klein commented on patch set 2 CR 0 10/01/18, 13:26

    PageRouter.php:113

    the method is used in SiteResolver and RouteDispatcher which do not catch this exception.
  13. Oliver Hader commented on patch set 2 10/01/18, 13:36

    PageRouter.php:113 Reply

    It's used in PageResolver only
  14. Susi Moog voted on patch set 2 V +1 CR +1 10/01/18, 13:38

  15. Susi Moog voted on patch set 2 V +2 CR +2 10/01/18, 13:39

  16. Susi Moog merged patch set 3 10/01/18, 13:39