58519[TASK] Add proper exception handling to RouterInterface logic
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Wouter Wolters +1
- Oliver Hader +1
-
Verified V +2
- Susi Moog +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Routing/Exception/RouteNotFoundException.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −1
- typo3/sysext/core/Classes/Routing/InvalidRouteArgumentsException.phpnew+24 −0
- typo3/sysext/core/Classes/Routing/PageRouter.php3+11 −9
- typo3/sysext/core/Classes/Routing/RouteNotFoundException.phpnew+24 −0
- typo3/sysext/core/Classes/Routing/RouterInterface.php+4 −2
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+2 −0
- typo3/sysext/frontend/Classes/Middleware/PageResolver.php+11 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php1+11 −6
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+0 −1
Review log 1416
-
Benni Mack uploaded patch set 1 10/01/18, 10:42
-
TYPO3com voted on patch set 1 V +1 10/01/18, 10:55 Completed build in 12m 11s on Mon, 1 Oct, 12:55 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29131
-
Mathias Brodala commented on patch set 1 10/01/18, 10:55
-
Benni Mack commented on patch set 2 10/01/18, 11:08
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 10/01/18, 11:18 Completed build in 09m 58s on Mon, 1 Oct, 01:18 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29132
-
Wouter Wolters voted on patch set 2 CR +1 10/01/18, 11:28
-
Oliver Hader voted on patch set 2 CR +1 10/01/18, 12:44
-
Oliver Hader voted on patch set 2 V +1 10/01/18, 13:13
-
Markus Klein commented on patch set 2 CR -1 10/01/18, 13:13
reviewing -
Markus Klein voted on patch set 2 CR +1 10/01/18, 13:21
-
Oliver Hader commented on patch set 2 10/01/18, 13:26
PageRouter.php:269Thanks! This was important since otherwise it lead to a PHP error since the strict return type did not match! +1 -
Markus Klein commented on patch set 2 CR 0 10/01/18, 13:26
PageRouter.php:113the method is used in SiteResolver and RouteDispatcher which do not catch this exception. -
Oliver Hader commented on patch set 2 10/01/18, 13:36
PageRouter.php:113ReplyIt's used in PageResolver only -
Susi Moog voted on patch set 2 V +1 CR +1 10/01/18, 13:38
-
Susi Moog voted on patch set 2 V +2 CR +2 10/01/18, 13:39
-
Susi Moog merged patch set 3 10/01/18, 13:39
PageLinkBuilder.php:374