Review main Merged

58520[TASK] Update CKEditor icon to meet the new CKEditor CD

Josef Glatz CR +2 V +2 Easy +5 −0 updated 10/01/18, 12:43

Commit message

This patch adds the newly added CKEditor v4 icon (via #86499)
to ext:rte_ckeditor as new extension icon.

`yarn && yarn build` was used to copy the file to the final location.

Review

  • Code review CR +2
    • Benjamin Kott +2
    • Wouter Wolters +1
    • Jan Stockfisch +1
    • Frank Nägler +1
  • Verified V +2
    • Benjamin Kott +2
    • Jan Stockfisch +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 910

  1. Josef Glatz uploaded patch set 1 10/01/18, 11:15

  2. Benjamin Kott voted on patch set 1 V +1 CR +1 10/01/18, 11:22

  3. Frank Nägler voted on patch set 1 V +1 CR +1 10/01/18, 11:22

  4. Benjamin Kott commented on patch set 1 V -1 CR -1 10/01/18, 11:23

    icon needs to be copied from icon repo for module
  5. Benjamin Kott commented on patch set 1 V +1 CR +1 10/01/18, 11:27

    wrong movie, everything is fine
  6. Wouter Wolters voted on patch set 1 CR +1 10/01/18, 11:29

  7. TYPO3com voted on patch set 1 V +1 10/01/18, 11:32 Completed build in 13m 04s on Mon, 1 Oct, 01:32 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29135

  8. Jan Stockfisch voted on patch set 1 V +1 CR +1 10/01/18, 11:38

  9. Benjamin Kott voted on patch set 1 V +2 CR +2 10/01/18, 12:43

  10. Benjamin Kott merged patch set 2 10/01/18, 12:43