Review main Merged

58521[TASK] Streamline phpdoc annotations in EXT:form

Benni Mack CR +2 V +2 Hard +48 −228 updated 10/01/18, 12:43

Commit message

EXT:form uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:form: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Review

  • Code review CR +2
    • Ralf Zimmermann +2
    • Wouter Wolters +1
  • Verified V +2
    • Ralf Zimmermann +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 78

Show 58 more files

Review log 45

  1. Benni Mack uploaded patch set 1 10/01/18, 11:21

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 10/01/18, 11:23

  3. TYPO3com voted on patch set 1 V +1 10/01/18, 11:42 Completed build in 18m 22s on Mon, 1 Oct, 01:42 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29137

  4. Ralf Zimmermann voted on patch set 1 V +2 CR +2 10/01/18, 12:43

  5. Ralf Zimmermann merged patch set 2 10/01/18, 12:43