58521[TASK] Streamline phpdoc annotations in EXT:form
Commit message
Review
-
Code review CR +2
- Ralf Zimmermann +2
- Wouter Wolters +1
-
Verified V +2
- Ralf Zimmermann +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 78
- typo3/sysext/form/Classes/Controller/AbstractBackendController.php+1 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −0
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −0
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −0
- typo3/sysext/form/Classes/Domain/Condition/Functions/FormConditionFunctionsProvider.php+16 −0
- typo3/sysext/form/Classes/Domain/Condition/ConditionProvider.php+1 −1
- typo3/sysext/form/Classes/Domain/Configuration/ArrayProcessing/ArrayProcessing.php+1 −0
- typo3/sysext/form/Classes/Domain/Configuration/ArrayProcessing/ArrayProcessor.php+1 −0
- typo3/sysext/form/Classes/Domain/Configuration/Exception/PropertyException.php+0 −2
- typo3/sysext/form/Classes/Domain/Configuration/Exception/PrototypeNotFoundException.php+0 −2
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinition/Validators/ValidationDto.php+0 −1
- typo3/sysext/form/Classes/Domain/Configuration/ConfigurationService.php+0 −1
- typo3/sysext/form/Classes/Domain/Exception/IdentifierNotValidException.php+0 −2
- typo3/sysext/form/Classes/Domain/Exception/RenderingException.php+0 −2
- typo3/sysext/form/Classes/Domain/Exception/TypeDefinitionNotFoundException.php+0 −2
- typo3/sysext/form/Classes/Domain/Exception/TypeDefinitionNotValidException.php+0 −2
- typo3/sysext/form/Classes/Domain/Exception/UnknownCompositRenderableException.php+1 −3
- typo3/sysext/form/Classes/Domain/Factory/AbstractFormFactory.php+0 −2
- typo3/sysext/form/Classes/Domain/Factory/FormFactoryInterface.php+0 −2
- typo3/sysext/form/Classes/Domain/Finishers/Exception/FinisherException.php+0 −2
Show 58 more files
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+0 −5
- typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php+1 −7
- typo3/sysext/form/Classes/Domain/Finishers/FinisherInterface.php+0 −4
- typo3/sysext/form/Classes/Domain/Finishers/FinisherVariableProvider.php+0 −4
- typo3/sysext/form/Classes/Domain/Model/Exception/DuplicateFormElementException.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/Exception/FinisherPresetNotFoundException.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/Exception/FormDefinitionConsistencyException.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/Exception/ValidatorPresetNotFoundException.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractFormElement.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+0 −8
- typo3/sysext/form/Classes/Domain/Model/FormElements/FormElementInterface.php+0 −9
- typo3/sysext/form/Classes/Domain/Model/FormElements/GenericFormElement.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/GridContainer.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/GridRow.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/Page.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/Section.php+0 −6
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+1 −4
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+0 −20
- typo3/sysext/form/Classes/Domain/Model/Renderable/RenderableInterface.php+0 −3
- typo3/sysext/form/Classes/Domain/Model/Renderable/RootRenderableInterface.php+0 −5
- typo3/sysext/form/Classes/Domain/Model/Renderable/VariableRenderableInterface.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/Exception.php+0 −2
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+0 −17
- typo3/sysext/form/Classes/Domain/Renderer/AbstractElementRenderer.php+0 −6
- typo3/sysext/form/Classes/Domain/Renderer/RendererInterface.php+0 −4
- typo3/sysext/form/Classes/Domain/Runtime/Exception/PropertyMappingException.php+0 −2
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+0 −23
- typo3/sysext/form/Classes/Domain/Exception.php+0 −2
- typo3/sysext/form/Classes/Hooks/FileListEditIconsHook.php+1 −0
- typo3/sysext/form/Classes/Hooks/FormFileExtensionUpdate.php+1 −0
- typo3/sysext/form/Classes/Hooks/FormFileProvider.php+1 −0
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+1 −0
- typo3/sysext/form/Classes/Mvc/Configuration/Exception/FileWriteException.php+1 −0
- typo3/sysext/form/Classes/Mvc/Configuration/Exception/NoSuchFileException.php+1 −0
- typo3/sysext/form/Classes/Mvc/Configuration/Exception/ParseErrorException.php+1 −0
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+3 −3
- typo3/sysext/form/Classes/Mvc/Persistence/FormPersistenceManagerInterface.php+0 −9
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+1 −0
- typo3/sysext/form/Classes/Mvc/Validation/Exception/InvalidValidationOptionsException.php+0 −1
- typo3/sysext/form/Classes/Mvc/Validation/CountValidator.php+0 −1
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php+0 −2
- typo3/sysext/form/Classes/Mvc/Validation/EmptyValidator.php+0 −2
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+0 −1
- typo3/sysext/form/Classes/Mvc/Validation/MimeTypeValidator.php+0 −2
- typo3/sysext/form/Classes/Service/TranslationService.php+0 −1
- typo3/sysext/form/Classes/Type/FormDefinitionArray.php+1 −0
- typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php+0 −4
- typo3/sysext/form/Classes/ViewHelpers/Form/TimePickerViewHelper.php+1 −2
- typo3/sysext/form/Classes/ViewHelpers/Form/UploadedResourceViewHelper.php+0 −2
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+5 −2
- typo3/sysext/form/Classes/ViewHelpers/RenderRenderableViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php+1 −3
- typo3/sysext/form/Classes/ViewHelpers/TranslateElementPropertyViewHelper.php+1 −3
- typo3/sysext/form/Classes/Exception.php+0 −2
- typo3/sysext/form/Tests/Unit/Mvc/Validation/Fixtures/TestValidator.php+1 −3
Review log 45
-
Benni Mack uploaded patch set 1 10/01/18, 11:21
-
Wouter Wolters voted on patch set 1 V +1 CR +1 10/01/18, 11:23
-
TYPO3com voted on patch set 1 V +1 10/01/18, 11:42 Completed build in 18m 22s on Mon, 1 Oct, 01:42 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29137
-
Ralf Zimmermann voted on patch set 1 V +2 CR +2 10/01/18, 12:43
-
Ralf Zimmermann merged patch set 2 10/01/18, 12:43