Review main Merged

58525[TASK] Streamline phpdoc annotations in EXT:fluid

Benni Mack CR +2 V +2 Normal +30 −159 updated 10/01/18, 13:50

Commit message

EXT:fluid uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:fluid: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Wouter Wolters +1
  • Verified V +2
    • Oliver Hader +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 60

Show 40 more files

Review log 68

  1. Benni Mack uploaded patch set 1 10/01/18, 11:58

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 10/01/18, 12:02

  3. TYPO3com voted on patch set 1 V -1 10/01/18, 12:04 Completed build in 41s on Mon, 1 Oct, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29147

  4. Benni Mack uploaded patch set 2 10/01/18, 12:39

  5. TYPO3com voted on patch set 2 V +1 10/01/18, 13:27 Completed build in 23m 47s on Mon, 1 Oct, 03:27 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29160

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 10/01/18, 13:45

  7. Oliver Hader voted on patch set 2 V +2 CR +2 10/01/18, 13:50

  8. Oliver Hader merged patch set 3 10/01/18, 13:50