Review main Merged

58527[TASK] Mark various parts with phpdoc internal

Benni Mack CR +2 V +2 Normal +59 −7 updated 10/01/18, 13:20

Commit message

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:felogin
- EXT:feedit
- EXT:filelist
- EXT:frontend
- EXT:fluid_styled_content
- EXT:impexp

All leftover @api methods have been removed.

Review

  • Code review CR +2
    • Susi Moog +2
    • Oliver Hader +1
  • Verified V +2
    • Susi Moog +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 49

Show 29 more files

Review log 56

  1. Benni Mack uploaded patch set 1 10/01/18, 12:13

  2. TYPO3com voted on patch set 1 V +1 10/01/18, 12:41 Completed build in 23m 24s on Mon, 1 Oct, 02:41 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29150

  3. Oliver Hader commented on patch set 1 10/01/18, 13:18

    DeleteFileViewHelper.php:25

    Additional description required here as well?

    AbstractPlugin.php:34

    Good one! ;-)
  4. Oliver Hader voted on patch set 1 V +1 CR +1 10/01/18, 13:19

  5. Susi Moog voted on patch set 1 V +2 CR +2 10/01/18, 13:20

  6. Susi Moog merged patch set 2 10/01/18, 13:20