Review main Merged

58529[TASK] Mark various parts with phpdoc internal - part 2

Benni Mack CR +2 V +2 Normal +57 −3 updated 10/01/18, 13:44

Commit message

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:seo
- EXT:setup
- EXT:rte_ckeditor
- EXT:workspaces
- EXT:viewpage
- EXT:tstemplate
- EXT:taskcenter
- EXT:t3editor
- EXT:sys_action
- EXT:sys_note

All leftover @api methods have been removed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Oliver Hader +1
  • Verified V +2
    • Wouter Wolters +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 48

Show 28 more files

Review log 45

  1. Benni Mack uploaded patch set 1 10/01/18, 12:39

  2. TYPO3com voted on patch set 1 V +1 10/01/18, 13:16 Completed build in 13m 20s on Mon, 1 Oct, 03:16 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29159

  3. Oliver Hader voted on patch set 1 V +1 CR +1 10/01/18, 13:24

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 10/01/18, 13:44

  5. Wouter Wolters merged patch set 2 10/01/18, 13:44