Review main Merged

58534[BUGFIX] Ensure Uri->getQuery() always returns a string

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 10/01/18, 16:59

Commit message

As stated in the Interface:
If no query string is present, this method MUST return an empty string.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Wolf +2
    • Mathias Brodala +1
  • Verified V +2
    • Markus Klein +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Goerz uploaded patch set 1 10/01/18, 14:50

  2. Mathias Brodala voted on patch set 1 CR +1 10/01/18, 14:59

  3. TYPO3com voted on patch set 1 V +1 10/01/18, 15:07 Completed build in 17m 06s on Mon, 1 Oct, 05:07 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29185

  4. Andreas Wolf voted on patch set 1 CR +2 10/01/18, 15:17

  5. Benni Mack voted on patch set 1 V +1 CR +2 10/01/18, 15:27

  6. Markus Klein voted on patch set 1 V +2 10/01/18, 16:58

  7. Markus Klein merged patch set 2 10/01/18, 16:59

  8. Markus Klein commented on patch set 2 10/01/18, 16:59

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 1b25bf4bf3b1bf736b0e94eb7ed83d5840cb9dc1