Review main Merged

58537[BUGFIX] Ensure most site related exceptions are handled

Markus Klein CR +2 V +2 Normal +104 −39 updated 10/01/18, 18:32

Commit message

Make sure that in most places any site related exception is handled
in a graceful way to avoid negative UX.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Jurian Janssen +1
    • Daniel Goerz +1
    • Richard Haeser +1
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1722

  1. Markus Klein uploaded patch set 1 10/01/18, 16:48

  2. TYPO3com voted on patch set 1 V -1 10/01/18, 16:48 Completed build in 11s on Mon, 1 Oct, 06:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29199

  3. Markus Klein updated the commit message in patch set 2 10/01/18, 16:49

  4. TYPO3com voted on patch set 2 V -1 10/01/18, 16:49 Completed build in 11s on Mon, 1 Oct, 06:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29200

  5. Markus Klein commented on patch set 3 10/01/18, 16:50

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V -1 10/01/18, 16:50 Completed build in 11s on Mon, 1 Oct, 06:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29201

  7. Markus Klein commented on patch set 4 10/01/18, 16:52

    Published edit on patch set 3.
  8. TYPO3com voted on patch set 4 V +1 10/01/18, 17:04 Completed build in 12m 03s on Mon, 1 Oct, 07:04 PM Test Summary: 36913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29202

  9. Andreas Wolf voted on patch set 4 CR +1 10/01/18, 17:45

  10. Benni Mack commented on patch set 4 10/01/18, 18:01

    PreviewController.php:175

    it is - it's a frigging Extbase route ;)
  11. Richard Haeser voted on patch set 4 CR +1 10/01/18, 18:03

  12. Benni Mack uploaded patch set 5 10/01/18, 18:03

  13. Benni Mack voted on patch set 5 V +1 CR +1 10/01/18, 18:04

  14. Richard Haeser voted on patch set 5 CR +1 10/01/18, 18:09

  15. Jurian Janssen voted on patch set 5 CR +1 10/01/18, 18:13

  16. Andreas Wolf voted on patch set 5 CR +2 10/01/18, 18:13

  17. Daniel Goerz voted on patch set 5 V +1 CR +1 10/01/18, 18:14

  18. Jörg Bösche voted on patch set 5 CR +1 10/01/18, 18:14

  19. Richard Haeser voted on patch set 5 V +1 10/01/18, 18:26

  20. TYPO3com voted on patch set 5 V +1 10/01/18, 18:29 Completed build in 21m 53s on Mon, 1 Oct, 08:29 PM Test Summary: 36928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29218

  21. Benni Mack voted on patch set 5 V +2 10/01/18, 18:32

  22. Benni Mack merged patch set 6 10/01/18, 18:32