Review main Abandoned

58546[WIP][TASK] Add default aspectRatios for social share images

Josef Glatz CR 0 V 0 Hard +269 −188 updated 10/29/18, 09:54

Commit message

This patch disables the default cropVariant for the out-of-the-box
available social sharing images and adds well-known and suggested
aspect ratios.

The editor still can use a free aspect ratio to crop an image according
to his wishes. The configuration of cropVariants can still be extended
or adjusted via typical TCA/Overrides in own extensions.

ToDo's
-------------
- Wait until Richard have new insight's after meeting with Yoast team
- \TYPO3\CMS\Seo\MetaTag\MetaTagGenerator::generateSocialImages needs
  to be checked if images are generated correctly
- Important RsT
- re-check if it's possible to overwrite cropVariant "default" instead
  of creating a new one (which is possibly the only way)

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1721

  1. Josef Glatz uploaded patch set 1 10/01/18, 20:19

  2. Josef Glatz commented on patch set 1 10/01/18, 20:20

    This adds all the necessary TCA changes. There might be some further changes in the MetaTagGenerator class. This has to be checked
  3. Richard Haeser commented on patch set 1 V -1 10/01/18, 20:22

    For now a -1 because we decided to not add this on the last moment before release. Besides that. Not only open graph have a default of 1.91:1. Also Twitter cards are the same ratio so we can use that too.
  4. Josef Glatz voted on patch set 1 CR -1 10/01/18, 20:23

  5. TYPO3com voted on patch set 1 V +1 10/01/18, 20:30 Completed build in 11m 19s on Mon, 1 Oct, 10:30 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29235

  6. Josef Glatz uploaded patch set 2 10/01/18, 20:31

  7. Josef Glatz commented on patch set 2 CR -1 10/01/18, 20:32

    Add config to both fields. This patch is postponed until 9.5.0 LTS is released
  8. Josef Glatz commented on patch set 2 10/01/18, 20:39

    > Add config to both fields. > > This patch is postponed until 9.5.0 LTS is released >= 9.5.1
  9. TYPO3com voted on patch set 2 V +1 10/01/18, 20:45 Completed build in 13m 57s on Mon, 1 Oct, 10:45 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29237

  10. Georg Ringer commented on patch set 2 10/01/18, 22:31

    can you also prepar an important rst already?

    pages.php:5

    wording not correct anymore
  11. Josef Glatz updated the commit message in patch set 3 10/02/18, 05:39

  12. Josef Glatz voted on patch set 3 V -1 CR -1 10/02/18, 05:39

  13. TYPO3com voted on patch set 3 V +1 10/02/18, 05:50 Completed build in 10m 26s on Tue, 2 Oct, 07:50 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29250

  14. Josef Glatz uploaded patch set 4 10/03/18, 05:51

  15. Josef Glatz voted on patch set 4 V -1 CR -1 10/03/18, 05:52

  16. TYPO3com voted on patch set 4 V -1 10/03/18, 06:02 Completed build in 10m 28s on Wed, 3 Oct, 08:02 AM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29283

  17. Richard Haeser commented on patch set 4 CR -1 10/28/18, 13:59

    pages.php:4

    Please be aware this file changed in master.

    pages.php:27

    I think it is ok to only ship 1.91:1 ratio and free. People can always add more ratios if they like. 1.91 is used in most of the cases by the social networks.
  18. Benni Mack commented on patch set 4 10/28/18, 16:45

    I opt for abandoning this patch then. OK, Josef?
  19. Richard Haeser commented on patch set 4 10/28/18, 16:46

    Well currently there is no aspect ratio at all. Maybe just add the 1.91:1?
  20. Richard Haeser commented on patch set 4 V -1 10/29/18, 08:40

    Refactoring this patch was a little bit too much work. Sorry Josef! Added a new patch: https://review.typo3.org/#/c/58774/. This one can be abandoned.
  21. Benni Mack abandoned the change 10/29/18, 09:54

    see new patch