Review main Merged

58548[TASK] Cleanup generation of sitemap-index-URLs

Stefan Neufeind CR +2 V +2 Easy +7 −2 updated 10/28/18, 12:48

Commit message

Use pageType-parameter from f:uri.page instead of providing
the type through additionalParams.
And don't include the page-parameter unless we are on another page
than the first one (page=0). Many DataProviders might only use one
page anyway.

Review

  • Code review CR +2
    • Benni Mack +2
    • Ursula Klinger +1
    • Daniel Goerz +1
    • Richard Haeser +1
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Stefan Neufeind uploaded patch set 1 10/01/18, 21:38

  2. Richard Haeser voted on patch set 1 V +1 CR +1 10/01/18, 21:42

  3. TYPO3com voted on patch set 1 V -1 10/01/18, 21:50 Completed build in 11m 13s on Mon, 1 Oct, 11:50 PM Test Summary: 3 of 38152 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29243

  4. Richard Haeser commented on patch set 1 CR -1 10/01/18, 21:53

    Test need to be adapted
  5. Richard Haeser commented on patch set 1 10/01/18, 21:57

    If this patch will not be merged in 9.5.0, I would prefer not removing the page parameter because it will change the cHash of the url. Although it is not a disaster to change the URL of a sitemap, it is preferred the url won't change.
  6. Stefan Neufeind uploaded patch set 2 10/01/18, 23:37

  7. Stefan Neufeind commented on patch set 2 10/01/18, 23:39

    I'd personally prefer the URLs to be short. If for most cases we don't use the page-parameter then it's just about the "sitemap"-parameter in the end if we still get a long cHash appended as well or not - one less param to care about when trying to generate clean URLs.
  8. TYPO3com voted on patch set 2 V +1 10/01/18, 23:48 Completed build in 11m 14s on Tue, 2 Oct, 01:48 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29249

  9. Jörg Bösche voted on patch set 2 CR +1 10/02/18, 21:12

  10. Richard Haeser voted on patch set 2 V +1 CR +1 10/28/18, 12:26

  11. Daniel Goerz voted on patch set 2 V +1 CR +1 10/28/18, 12:29

  12. Benni Mack voted on patch set 2 V +2 CR +2 10/28/18, 12:35

  13. Benni Mack merged patch set 3 10/28/18, 12:35

  14. Ursula Klinger voted on patch set 3 CR +1 10/28/18, 12:48