58548[TASK] Cleanup generation of sitemap-index-URLs
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Ursula Klinger +1
- Daniel Goerz +1
- Richard Haeser +1
- Jörg Bösche +1
-
Verified V +2
- Benni Mack +2
- Daniel Goerz +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1214
-
Stefan Neufeind uploaded patch set 1 10/01/18, 21:38
-
Richard Haeser voted on patch set 1 V +1 CR +1 10/01/18, 21:42
-
TYPO3com voted on patch set 1 V -1 10/01/18, 21:50 Completed build in 11m 13s on Mon, 1 Oct, 11:50 PM Test Summary: 3 of 38152 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29243
-
Richard Haeser commented on patch set 1 CR -1 10/01/18, 21:53
Test need to be adapted -
Richard Haeser commented on patch set 1 10/01/18, 21:57
If this patch will not be merged in 9.5.0, I would prefer not removing the page parameter because it will change the cHash of the url. Although it is not a disaster to change the URL of a sitemap, it is preferred the url won't change. -
Stefan Neufeind uploaded patch set 2 10/01/18, 23:37
-
Stefan Neufeind commented on patch set 2 10/01/18, 23:39
I'd personally prefer the URLs to be short. If for most cases we don't use the page-parameter then it's just about the "sitemap"-parameter in the end if we still get a long cHash appended as well or not - one less param to care about when trying to generate clean URLs. -
TYPO3com voted on patch set 2 V +1 10/01/18, 23:48 Completed build in 11m 14s on Tue, 2 Oct, 01:48 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29249
-
Jörg Bösche voted on patch set 2 CR +1 10/02/18, 21:12
-
Richard Haeser voted on patch set 2 V +1 CR +1 10/28/18, 12:26
-
Daniel Goerz voted on patch set 2 V +1 CR +1 10/28/18, 12:29
-
Benni Mack voted on patch set 2 V +2 CR +2 10/28/18, 12:35
-
Benni Mack merged patch set 3 10/28/18, 12:35
-
Ursula Klinger voted on patch set 3 CR +1 10/28/18, 12:48