Review main Merged

58549[BUGFIX] Reduce amount of false positives of extension scanner

Georg Ringer CR +2 V +2 Easy +6 −41 updated 10/01/18, 23:19

Commit message

Reduce amount of false positives introduced with #86366 as methods
like 'getTitle()' are used too often.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1115

  1. Georg Ringer uploaded patch set 1 10/01/18, 22:21

  2. Georg Ringer uploaded patch set 2 10/01/18, 22:22

  3. Georg Ringer uploaded patch set 3 10/01/18, 22:23

  4. TYPO3com voted on patch set 1 V +1 10/01/18, 22:34 Completed build in 12m 40s on Tue, 2 Oct, 12:34 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29244

  5. Richard Haeser voted on patch set 3 CR +1 10/01/18, 22:34

  6. TYPO3com voted on patch set 2 V +1 10/01/18, 22:37 Completed build in 14m 09s on Tue, 2 Oct, 12:37 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29245

  7. TYPO3com voted on patch set 3 V +1 10/01/18, 22:41 Completed build in 13m 13s on Tue, 2 Oct, 12:41 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29246

  8. Christian Kuhn voted on patch set 3 CR +1 10/01/18, 22:52

  9. Georg Ringer uploaded patch set 4 10/01/18, 22:56

  10. Christian Kuhn commented on patch set 3 10/01/18, 22:58

    Deprecation-86366-MethodsInAbstractUpdate.rst:24

    one getDescription too much
  11. Christian Kuhn commented on patch set 3 10/01/18, 22:58

    Deprecation-86366-MethodsInAbstractUpdate.rst:24 Reply

    ah, you found that already. thx georg.
  12. Christian Kuhn voted on patch set 4 V +1 CR +1 10/01/18, 22:59

  13. TYPO3com voted on patch set 4 V +1 10/01/18, 23:07 Completed build in 10m 37s on Tue, 2 Oct, 01:07 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29247

  14. Stefan Neufeind voted on patch set 4 V +2 CR +2 10/01/18, 23:19

  15. Stefan Neufeind merged patch set 5 10/01/18, 23:19